Fixes WARNING Failed merging new config value
With these changes, the previous Failed merging
errors:
17966 (InDet::InDetBoundaryCheckTool/InDetBoundaryCheckTool)
53898 (InDet::InDetTrackSummaryHelperTool/InDetSummaryHelper)
17966 (PixelDCSCondStateAlg/PixelDCSCondStateAlg)
17966 (PixelDCSCondStatusAlg/PixelDCSCondStatusAlg)
17966 (PixelDeadMapCondAlg/PixelDeadMapCondAlg)
8983 (TileBadChanTool/TileBadChanTool)
8983 (Trk::Navigator/AtlasNavigator)
reduce to these two:
bash-4.2$ grep "WARNING Failed merging new config value" log.RAWtoALL
Py:conf2toConfigurable WARNING Failed merging new config value (/PIXEL/DCS/FSMSTATE) and old config value (ConditionStore+) for (ReadKeyState) property of PixelDCSCondStateAlg/PixelDCSCondStateAlg (PixelDCSCondStateAlg/PixelDCSCondStateAlg) old (new). Will take value from NEW configuration, but this should be checked!
Py:conf2toConfigurable WARNING Failed merging new config value (/PIXEL/DCS/FSMSTATUS) and old config value (ConditionStore+) for (ReadKeyStatus) property of PixelDCSCondStatusAlg/PixelDCSCondStatusAlg (PixelDCSCondStatusAlg/PixelDCSCondStatusAlg) old (new). Will take value from NEW configuration, but this should be checked!
These need an expert to look into them.
For the ones this MR fixes, there are two types - real ones, from incompletely setup new configuration, and false positives due to GaudiConf2 reporting DataHandle values differently.
Merge request reports
Activity
added Core InnerDetector Reconstruction master review-pending-level-1 labels
CI Result SUCCESS (hash 3dee5a94)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28743]added review-approved label and removed review-pending-level-1 label
As discussed with @goetz I will revert the change to
SCT_DCS
, since he addresses this in !40862 (merged)added NewConfig label
added review-pending-level-1 label and removed review-approved label
- Resolved by Edward Moyse
Hi @emoyse,
This looks good to me, but is it worth running with full-unit-tests to catch anything unexpected?
Cheers,
John
CI Result SUCCESS (hash 6156c1ab)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28766]added review-user-action-required label and removed review-pending-level-1 label
added full-unit-tests label
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 6156c1ab)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28786]added review-approved label and removed review-pending-level-1 label
mentioned in commit 1f135d78
added sweep:ignore label