Skip to content
Snippets Groups Projects

Many features added to JetMacher + JetHistoMatchedFiller

Merged Jannik Geisen requested to merge jgeisen/athena:jgeisen_JetMatcherUpdates into master
All threads resolved!

I added a few features to the existing JetMatcherAlg as well as JetHistoMatchedFiller in the offline MT JetMonitoring. Many of these were suggested in this post.

This includes:

  • Matching PFlow to EM jet (offline to offline)
  • Monitor not only the pT difference between matched jets, but also energy and mass difference as well as the responses for each variable. Additionally, we monitor the pT and eta of the reference (=offline) jets to be able to create 2D histograms in coarse bins of eta or pT. Note that I duplicated the configuration of the specifications & histograms for online and offline jets, so that we can configure them both individually, rather than having the same setup for both.
  • We are able to specify the calibration scale of the probed (=usually HLT) jets, so we can check different calibration scales. This could easily be extended/modified to have this feature also (or only) for the reference jets.
  • Before, the JetMatcher had a slight bug which caused it to sometimes match a jet to another one that had already been matched previously. This happened in 22 of 500 test events. This is now fixed.
  • Mini bonus: adding JVT relevant variables for chains that have a JVT selection (if relevant?)

Tagging @jbossios @valentem

Edited by Jannik Geisen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jannik Geisen added 1 commit

    added 1 commit

    • 49220a69 - remove printouts, adding response plots for matched jets

    Compare with previous version

  • Jannik Geisen changed the description

    changed the description

  • Jannik Geisen resolved all threads

    resolved all threads

  • Jannik Geisen marked this merge request as ready

    marked this merge request as ready

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • Reconstruction/Jet/JetMonitoring
    • Trigger/TrigMonitoring/TrigJetMonitoring

    Affected files list will not be printed in this case

    Adding @goetz as watcher

  • :white_check_mark: CI Result SUCCESS (hash 49220a69)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28869]

  • The thread is resolved and the code changes look fine, approving. Pienpen(L1)

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Edward Moyse mentioned in commit bfd676f0

    mentioned in commit bfd676f0

  • Please register or sign in to reply
    Loading