Remove metadata support for TAGs, which have not been supported for ages.

TAGs have never really been used, nor is the metadata supported there. This adds needless complexity to the code, so time to remove.

This merge request affects 6 packages:

• AtlasTest/DatabaseTest/AthenaPoolMultiTest
• Control/AthenaKernel
• Database/AthenaPOOL/AthenaPoolUtilities
• Database/AthenaPOOL/DBDataModel
• Database/RegistrationServices
• LumiBlock/LumiCalc

Affected files list will not be printed in this case

Adding @ssnyder ,@mnowak as watchers

added Core DQ Database JetEtmiss Test master review-pending-level-1 labels

Tag @mnowak , @tcuhadar , yell if you really need this...

marked this merge request as draft

CI Result FAILURE (hash b0ab81ab)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 45, warnings 135
AthSimulation: number of compilation errors 15, warnings 6
AthGeneration: number of compilation errors 8, warnings 4
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 7, warnings 12
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28794]

added 1 commit

• 8557da53 - Remove DBDataModel from CMakeLists.txt files

Compare with previous version

added full-build full-unit-tests labels

marked this merge request as ready

marked this merge request as draft

build area is cleaned as MR is labeled as full-build

This merge request affects 7 packages:

• AtlasTest/DatabaseTest/AthenaPoolMultiTest
• Control/AthenaKernel
• Database/AthenaPOOL/AthenaPoolUtilities
• Database/AthenaPOOL/DBDataModel
• Database/RegistrationServices
• LumiBlock/LumiBlockComps
• LumiBlock/LumiCalc

Affected files list will not be printed in this case

Adding @ssnyder ,@mnowak as watchers

CI Result FAILURE (hash 8557da53)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 31
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28798]

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• bc509466 - Remove #include

Compare with previous version

marked this merge request as ready

build area is cleaned as MR is labeled as full-build

This merge request affects 7 packages:

• AtlasTest/DatabaseTest/AthenaPoolMultiTest
• Control/AthenaKernel
• Database/AthenaPOOL/AthenaPoolUtilities
• Database/AthenaPOOL/DBDataModel
• Database/RegistrationServices
• LumiBlock/LumiBlockComps
• LumiBlock/LumiCalc

Affected files list will not be printed in this case

Adding @ssnyder ,@mnowak as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash bc509466)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28861]

Looks like there are still some cmake warnings.

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• a513bd2a - Remove DBDataModel from package_filters.txt to avoid warnings.

Compare with previous version

Thanks Mike, apparently removing a package is a little more involved, but hopefully the latest commit will take care of the warning. Peter

removed review-user-action-required label

build area is cleaned as MR is labeled as full-build

This merge request affects 10 packages:

• AtlasTest/DatabaseTest/AthenaPoolMultiTest
• Control/AthenaKernel
• Database/AthenaPOOL/AthenaPoolUtilities
• Database/AthenaPOOL/DBDataModel
• Database/RegistrationServices
• LumiBlock/LumiBlockComps
• LumiBlock/LumiCalc
• Projects/AthAnalysis
• Projects/AthGeneration
• Projects/AthSimulation

Affected files list will not be printed in this case

Adding @krumnack ,@jchapman ,@akraszna ,@ssnyder ,@mnowak as watchers

added Build review-pending-level-1 labels

CI Result FAILURE (hash a513bd2a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28937]

I think this failure is the same as in the nightly. Should hopefully be fixed, once !41026 (merged) is merged.

The MR you linked is not related.

I don't think the testing error is exactly the same error as in the nightly either, so not obvious (to me) where this came from. @gemmeren, do you want to retry? Ordinarily I would just launch it, but since it's full-build and full-unit-tests, it will obviously take a while. -Mike (L1)

Should be retried once !41040 (merged) is merged.

resolved all threads

Thanks @mhance, @tadej,

This isn't super urgent, but the full-build and full-unit-tests didn't show test failures on the previous hash bc509466 and the commit after only affects AthSimulation, AthGeneration, AthAnalysis to remove the explicit dependence on the (removed) DBDataModel package.

So I am not sure that we really need a CI retry (but I am ok with whatever), Peter

Sorry, I was looking quickly. In that case, @mhance can you give it another quick look and approve it?

Hi @tadej, sounds good. I had already looked, the changes seem fine, and I agree the failure is likely unrelated, since the tests passed on the previous build. L1 approving.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit b148cb66

added sweep:ignore label