tauRecTools: replace charged PFOs with tau tracks, and fix "bug/feature" in MVA TES

Hello,

In R22, we are not writing out tau charged PFOs in xAODs, because tau charged PFOs are supposed to be identical to tau tracks. In this MR, we "safely replace" charged PFOs with tau tracks in one tool, so that the tool can be rerun on xAODs.

However... charged PFOs are actually only created for taus that have 1-5 tracks: https://gitlab.cern.ch/atlas/athena/-/blob/master/Reconstruction/tauRecTools/src/TauPi0ClusterScaler.cxx#L29-44

This must have been overlooked in the MVA tau energy scale code, where "charged_totalE" is supposed to be the total energy carried by tau tracks, even when taus have more than 5 tracks... The "charged_totalE" variable was null for taus with more than 5 tracks (these taus not used in analyses fortunately), and the behaviour is now fixed. This MR does not change the reconstruction output for taus with at most 5 tracks.

Cheers, Bertrand

This merge request affects 1 package:

• Reconstruction/tauRecTools

This merge request affects 1 file:

• Reconstruction/tauRecTools/Root/MvaTESVariableDecorator.cxx

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added Reconstruction Tau master review-pending-level-1 labels

Tagging @qbuat for information, and @veellajo @rferguso in case it affects PhysVal/DQ.

CI Result SUCCESS (hash 919faa50)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29087]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 2fc2088b

added sweep:ignore label