Skip to content
Snippets Groups Projects

ElectronLikelihood tool : Removing deprecated methods, formatting the code

Merged ElectronLikelihood tool : Removing deprecated methods, formatting the code
ATLAS-EGamma/athena:ElectronLH_remove_unused_method into master
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:ElectronLH_remove_unused_method into master

Merge request reports

Pipeline #2354228 passed

Stage: external

    Pipeline passed for 4ffb4f7c on ATLAS-EGamma:ElectronLH_remove_unused_method

    Approval is optional

    Merged by Adam Edward BartonAdam Edward Barton 4 years ago (Mar 1, 2021 4:30pm UTC)

    Merge details

    • Changes merged into master with 9edde764 (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

      This merge request affects 5 files:

      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/ElectronPhotonSelectorTools/AsgElectronLikelihoodTool.h
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/AsgElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/AsgForwardElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/TElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/TElectronLikelihoodTool.h
    • ATLAS Robot added Analysis Derivation Egamma master review-pending-level-1 labels

      added Analysis Derivation Egamma master review-pending-level-1 labels

    • Christos Anastopoulos added 1 commit

      added 1 commit

      Compare with previous version

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

      This merge request affects 5 files:

      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/ElectronPhotonSelectorTools/AsgElectronLikelihoodTool.h
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/AsgElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/AsgForwardElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/TElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/TElectronLikelihoodTool.h
    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :negative_squared_cross_mark: CI Result FAILURE (hash abcfb8e1)

      Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :o: :white_check_mark: :white_check_mark: :white_check_mark: :o:
      required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :o: Athena: number of compilation errors 1, warnings 1
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :o: AthAnalysis: number of compilation errors 1, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29102]

    • Christos Anastopoulos added 1 commit

      added 1 commit

      Compare with previous version

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :negative_squared_cross_mark: CI Result FAILURE (hash a2708b73)

      Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :o: :white_check_mark: :white_check_mark: :white_check_mark: :o:
      required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :o: Athena: number of compilation errors 1, warnings 4
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :o: AthAnalysis: number of compilation errors 1, warnings 1
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29101]

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

      This merge request affects 5 files:

      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/ElectronPhotonSelectorTools/AsgElectronLikelihoodTool.h
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/AsgElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/AsgForwardElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/TElectronLikelihoodTool.cxx
      • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/TElectronLikelihoodTool.h
    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash 4ffb4f7c)

      Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29110]

    • Louis-Guillaume Gagnon added review-approved label and removed review-pending-level-1 label

      added review-approved label and removed review-pending-level-1 label

    • Adam Edward Barton mentioned in commit 9edde764

      mentioned in commit 9edde764

    • Adam Edward Barton merged

      merged

    • Atlas Nightlybuild added sweep:ignore label

      added sweep:ignore label

    Please register or sign in to reply