Skip to content
Snippets Groups Projects

Added method to collect data dependencies of CA

Merged Tomasz Bold requested to merge tbold/athena:ca-data-detps into master
All threads resolved!

This the initial implementation of a method that allows answering questions about the IO of the CA. The intention is that it will give an early warning that a CA is incomplete. Specifically, in HLT, we expect that CAs representing a reco of a single step will only require extra dependencies that are explicitly known. With this functionality, we will be able to check it. (@bwynne will enjoy it). Also tagging @fwinkl FI as it is all based on his work in Gaudi data handles. Tagging @wlampl FI

One caveat is that private tools that are not assigned are not checked. I think we could do that if needed. I.e. we can always instantiate them and pick necessary properties.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Winklmeier
  • Frank Winklmeier
  • Tomasz Bold added 1 commit

    added 1 commit

    • 54b10eb0 - Run IO test only in Athena project

    Compare with previous version

  • This merge request affects 1 package:

    • Control/AthenaConfiguration

    This merge request affects 2 files:

    • Control/AthenaConfiguration/python/ComponentAccumulator.py
    • Control/AthenaConfiguration/python/ComponentAccumulatorTest.py

    Adding @ssnyder as watcher

  • :negative_squared_cross_mark: CI Result FAILURE (hash a31d5de5)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :o: :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29193]

  • :white_check_mark: CI Result SUCCESS (hash 54b10eb0)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29196]

  • Setting review-user-action-required until open discussions are resolved.

  • Tomasz Bold added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Control/AthenaConfiguration

    This merge request affects 4 files:

    • Control/AthenaConfiguration/CMakeLists.txt
    • Control/AthenaConfiguration/python/ComponentAccumulator.py
    • Control/AthenaConfiguration/python/ComponentAccumulatorTest.py
    • Control/AthenaConfiguration/python/ComponentAccumulatorTestReco.py

    Adding @ssnyder as watcher

  • :white_check_mark: CI Result SUCCESS (hash e9cc0458)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29244]

  • Hi,

    this looks fine from L1 side. Just to be on the safe side: can the remaining discussion be resolved?

    Thanks, Volker (L1)

  • Volker Andreas Austrup resolved all threads

    resolved all threads

  • mentioned in commit f0bc2fb1

  • Please register or sign in to reply
    Loading