Skip to content
Snippets Groups Projects

Clean-up setting of ConfigFlag.Detector. flags

Merged Clean-up setting of ConfigFlag.Detector. flags
jchapman/athena:DetectorFlagCleanup_master into master
Merged John Derek Chapman requested to merge jchapman/athena:DetectorFlagCleanup_master into master

This merge request cleans up how ConfigFlag.Detector.(Geometry/Simulate)XXX flags are set Simulation configuration. Once this is done, then it will be easier to clean-up how they are used within the configuration.

Edited by John Derek Chapman

Merge request reports

Pipeline #2369925 passed

Stage: external

    Pipeline passed for 77f01126 on jchapman:DetectorFlagCleanup_master

    Merged by Adam Edward BartonAdam Edward Barton 4 years ago (Mar 5, 2021 3:13pm UTC)

    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • John Derek Chapman added 205 commits

    added 205 commits

    • b26e6bcc...8e3c2864 - 203 commits from branch atlas:master
    • 2e9e98d1 - Clean-up G4Atlas and ISF Skeletons
    • 544ef2b7 - Use helper method to set Detector.Simulate ConfigFlags in tests

    Compare with previous version

  • John Derek Chapman added 1 commit

    added 1 commit

    • 69f62390 - Use helper method to set Detector.Simulate ConfigFlags in tests

    Compare with previous version

  • John Derek Chapman added 1 commit

    added 1 commit

    • 155b911d - Use helper method to set Detector.Simulate ConfigFlags in tests

    Compare with previous version

  • John Derek Chapman added 1 commit

    added 1 commit

    • 75038dbc - Use helper method to set Detector.Simulate ConfigFlags in tests

    Compare with previous version

  • John Derek Chapman added 3 commits

    added 3 commits

    • 7eba2266 - Add getDefaultDetectorsForRun method to DetectorConfigFlags.py
    • fde5d55b - Clean-up G4Atlas and ISF Skeletons
    • 42f14f57 - Use helper method to set Detector.Simulate ConfigFlags in tests

    Compare with previous version

  • John Derek Chapman added 2 commits

    added 2 commits

    • bccdee6a - Clean-up G4Atlas and ISF Skeletons
    • 77f01126 - Use helper method to set Detector.Simulate ConfigFlags in tests

    Compare with previous version

  • John Derek Chapman resolved all threads

    resolved all threads

  • John Derek Chapman marked this merge request as ready

    marked this merge request as ready

  • John Derek Chapman added NewConfig label

    added NewConfig label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as the previous build was for the MR labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 7 packages:

    • Simulation/G4Atlas/G4AtlasAlg
    • Simulation/G4Atlas/G4AtlasServices
    • Simulation/G4Atlas/G4AtlasTools
    • Simulation/ISF/ISF_Config
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
    • Simulation/SimuJobTransforms

    Affected files list will not be printed in this case

    Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@schaarsc ,@tadej ,@xiaozhon as watchers

  • ATLAS Robot added Simulation master review-pending-level-1 labels

    added Simulation master review-pending-level-1 labels

  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Author Owner

    Jenkins please retry a build

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply