ATLASRECTS-5932: PatternParameters Propagate the changes of using unique_ptr for TrackParameters

PatternParameters Propagate the changes of using unique_ptr for TrackParameters

Mentioning @sroe

This merge request affects 1 package:

• Tracking/TrkEvent/TrkPatternParameters

This merge request affects 2 files:

• Tracking/TrkEvent/TrkPatternParameters/TrkPatternParameters/PatternTrackParameters.h
• Tracking/TrkEvent/TrkPatternParameters/src/PatternTrackParameters.cxx

Adding @gavrilen ,@amorley as watchers

added JetEtmiss Tracking master review-pending-level-1 labels

CI Result FAILURE (hash c3ded30e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29215]

added 1 commit

• ca74bb1d - SiTrajectoryElement_xk propagate unique_ptr

Compare with previous version

changed title from ATLASRECTS-5932: PatternParameters Propagate the changes to unique_ptr of TrackParameters to ATLASRECTS-5932: PatternParameters Propagate the changes of using unique_ptr for TrackParameters

changed the description

This merge request affects 2 packages:

• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• Tracking/TrkEvent/TrkPatternParameters

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

added InnerDetector label

CI Result FAILURE (hash ca74bb1d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29217]

Hi @christos,

I've added two small comments. Can you please take a look?

Thanks, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

marked this merge request as draft

added 1 commit

• eb9b15c3 - Run full clang-tidy modernize for nullptr, avoid use after move

Compare with previous version

marked this merge request as ready

resolved all threads

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• Tracking/TrkEvent/TrkPatternParameters

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash eb9b15c3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29267]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 9b46700d

added sweep:ignore label