Clean-up of ConfigFlags.Detector.SimulateXXX usage

This merge request follows on from !41181 (merged). Now all usage of ConfigFlags.Detector.Simulate is removed and replaced with either ConfigFlags.Detector.Geometry (for cases related to building the detector and how the detector is simulated) or ConfigFlags.Detector.Enable (for cases related to SensitiveDetectors and writing out Sim Hit Collections). This reduces the granularity of the configuration slightly, as it removes the ability to switch on a sensitive detector without writing out the Sim Hits, but such configurations were only used in local debugging/profiling and can be manually configured in such cases.
(Needs to go in after !41291 (merged)) FYI @dnoel, @bleban.

added 4 commits

• 69f62390 - Use helper method to set Detector.Simulate ConfigFlags in tests
• 7140784c - Replace use of ConfigFlags.Detector.SimulateXXX
• cec6fdb2 - Remove Detector.SimulateHGTD usage in LArDigitizationConfigNew module
• bf11f0fe - Use ConfigFlags.Detector.Enable to configure hit collection writing

Compare with previous version

added 6 commits

• 155b911d - Use helper method to set Detector.Simulate ConfigFlags in tests
• 5d011c01 - Replace use of ConfigFlags.Detector.SimulateXXX
• e34f9aba - Remove Detector.SimulateHGTD usage in LArDigitizationConfigNew module
• ab54fd12 - Use ConfigFlags.Detector.Enable to configure hit collection writing
• 8f3bae8d - Use Common configuration for StreamHITS ItemList
• 42449ff1 - Drop unneeded extra configuration on TileGeoG4SDCalc

Compare with previous version

Jenkins please retry a build

This merge request affects 14 packages:

• AtlasGeometryCommon/SubDetectorEnvelopes
• DetectorDescription/GeoModel/AtlasGeoModel
• InnerDetector/InDetConfig
• InnerDetector/InDetRawAlgs/InDetOverlay
• LArCalorimeter/LArDigitization
• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasServices
• Simulation/G4Atlas/G4AtlasTools
• Simulation/G4Sim/MCTruthBase
• Simulation/ISF/ISF_Config
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
• Simulation/ISF/ISF_HepMC/ISF_HepMC_Tools
• Simulation/SimuJobTransforms

Affected files list will not be printed in this case

Adding @cgrefe ,@jchapman ,@mfauccig ,@xiaozhon ,@jojungge ,@ahaas ,@schaarsc ,@goetz ,@pjacka ,@pavol ,@tkharlam ,@sroe ,@calfayan ,@ahasib ,@tadej ,@rbianchi as watchers

added Digitization Geometry InnerDetector JetEtmiss LAr Overlay Simulation master labels

CI Result FAILURE (hash 42449ff1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29345]

added 2 commits

• a2416ea2 - Use Common configuration for StreamHITS ItemList
• 8336a932 - Drop unneeded extra configuration on TileGeoG4SDCalc

Compare with previous version

added 5 commits

• 868b2c8e - Replace use of ConfigFlags.Detector.SimulateXXX
• 1ca7bdde - Remove Detector.SimulateHGTD usage in LArDigitizationConfigNew module
• 37123a33 - Use ConfigFlags.Detector.Enable to configure hit collection writing
• 27be11da - Use Common configuration for StreamHITS ItemList
• 8fbd0ede - Drop unneeded extra configuration on TileGeoG4SDCalc

Compare with previous version

Jenkins please retry a build

This merge request affects 14 packages:

• AtlasGeometryCommon/SubDetectorEnvelopes
• DetectorDescription/GeoModel/AtlasGeoModel
• InnerDetector/InDetConfig
• InnerDetector/InDetRawAlgs/InDetOverlay
• LArCalorimeter/LArDigitization
• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasServices
• Simulation/G4Atlas/G4AtlasTools
• Simulation/G4Sim/MCTruthBase
• Simulation/ISF/ISF_Config
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
• Simulation/ISF/ISF_HepMC/ISF_HepMC_Tools
• Simulation/SimuJobTransforms

Affected files list will not be printed in this case

Adding @cgrefe ,@jchapman ,@mfauccig ,@xiaozhon ,@jojungge ,@ahaas ,@schaarsc ,@goetz ,@pjacka ,@pavol ,@tkharlam ,@sroe ,@calfayan ,@ahasib ,@tadej ,@rbianchi as watchers

added 6 commits

• 75038dbc - Use helper method to set Detector.Simulate ConfigFlags in tests
• d5e61038 - Replace use of ConfigFlags.Detector.SimulateXXX
• 4abadc2b - Remove Detector.SimulateHGTD usage in LArDigitizationConfigNew module
• ddab26ba - Use ConfigFlags.Detector.Enable to configure hit collection writing
• 924c2981 - Use Common configuration for StreamHITS ItemList
• 3abc6d8e - Drop unneeded extra configuration on TileGeoG4SDCalc

Compare with previous version

resolved all threads

CI Result SUCCESS (hash 8fbd0ede)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29367]

added 7 commits

• bccdee6a - Clean-up G4Atlas and ISF Skeletons
• 77f01126 - Use helper method to set Detector.Simulate ConfigFlags in tests
• 95bc6560 - Replace use of ConfigFlags.Detector.SimulateXXX
• d4684da0 - Remove Detector.SimulateHGTD usage in LArDigitizationConfigNew module
• ee2b94cc - Use ConfigFlags.Detector.Enable to configure hit collection writing
• d14558b6 - Use Common configuration for StreamHITS ItemList
• 35a69aaa - Drop unneeded extra configuration on TileGeoG4SDCalc

Compare with previous version

@nstyles, FYI this also touches a bit the ITk test.

added 117 commits

• 35a69aaa...81c0cba7 - 111 commits from branch atlas:master
• 156529e0 - Clean-up G4Atlas and ISF Skeletons
• 9334b6e4 - Use helper method to set Detector.Simulate ConfigFlags in tests
• 2a9588cd - Replace use of ConfigFlags.Detector.SimulateXXX
• 8835a60f - Use ConfigFlags.Detector.Enable to configure hit collection writing
• 60cfb592 - Use Common configuration for StreamHITS ItemList
• a1de261a - Drop unneeded extra configuration on TileGeoG4SDCalc

Compare with previous version

added 20 commits

• a1de261a...e1fe5984 - 16 commits from branch atlas:master
• d7984466 - Replace use of ConfigFlags.Detector.SimulateXXX
• 443fa7c6 - Use ConfigFlags.Detector.Enable to configure hit collection writing
• 5de6e32f - Use Common configuration for StreamHITS ItemList
• 79cffe48 - Drop unneeded extra configuration on TileGeoG4SDCalc

Compare with previous version

changed the description

added NewConfig label