ISF FastCaloSim CA migration: ParticleBroker, UserAction, InputConverter bug fixes

Steps towards making old and new style FastCaloSim configuration identical.

Applying these bugfixes, running MT on one thread makes old vs. new config identical. Many differences still occur when running on multiple threads.

FYI: @jchapman

added NewConfig label

added 309 commits

• 21158c86...61b35b20 - 307 commits from branch atlas:master
• 91ebb8aa - ParticleBroker and UserAction bug fixes
• ba60a2be - Input converter bug fix

Compare with previous version

marked this merge request as ready

changed title from WIP: ParticleBroker and UserAction !partial! fix to ISF FastCaloSim CA migration: ParticleBroker, UserAction, InputConverter bug fixes

changed the description

This merge request affects 3 packages:

• Simulation/G4Atlas/G4AtlasServices
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_Geant4/ISF_Geant4Tools

Affected files list will not be printed in this case

Adding @jchapman as watcher

added Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash ba60a2be)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29755]

added review-approved label and removed review-pending-level-1 label

These changes look good to me. Approving as simulation "expert".

Cheers,

John

merged

mentioned in commit ac62dd96

added sweep:ignore label