Read IOV Condition objects using dedicated PersSvc instance
IOVSvc is requesting reading of its IOV Conditions objects into a dedicated PersistencySvc instance (context), so all conditions files can be closed by simply deleting this instance. This was up to now ignored by PoolSvc/ConversionSvc (by mistake). Here I am fixing this mistake and adding context-awarness to 2 converters that read objects containing POOL Refs to other object (DataHeaderCnv and CoolMultChanCnv). I also add EndProcessing incident trigger to IOVDbSvc because in AthenaMT the StoreCleared incident is not fired (this is to trigger Condition files closing after the first Event)
Merge request reports
Activity
-
This merge request affects 8 packages:
- Control/IOVSvc
- Database/APR/StorageSvc
- Database/AthenaPOOL/AthenaPoolCnvSvc
- Database/AthenaPOOL/AthenaPoolExample/AthenaPoolExampleAlgorithms
- Database/AthenaPOOL/EventSelectorAthenaPool
- Database/AthenaPOOL/PoolSvc
- Database/IOVDbSvc
- Database/PersistentDataModelAthenaPool
Affected files list will not be printed in this case
added Core Database JetEtmiss master review-pending-level-1 labels
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals 
cmake make required tests 
optional tests Full details available on this CI monitor view
@mnowak this broke the AthenaPoolExampleAlgorithms_AthenaPoolExample_Write_ctest unit test -- L1
added review-user-action-required label and removed review-pending-level-1 label
Resolved by Louis-Guillaume GagnonNo, these tests are broken since last week. But there is a MR !41379 (merged) with a fix, so we need to wait for it to go in and retry.
Cheers, Marcin- Last reply by Louis-Guillaume Gagnon
-
-
This merge request affects 8 packages:
- Control/IOVSvc
- Database/APR/StorageSvc
- Database/AthenaPOOL/AthenaPoolCnvSvc
- Database/AthenaPOOL/AthenaPoolExample/AthenaPoolExampleAlgorithms
- Database/AthenaPOOL/EventSelectorAthenaPool
- Database/AthenaPOOL/PoolSvc
- Database/IOVDbSvc
- Database/PersistentDataModelAthenaPool
Affected files list will not be printed in this case
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
- Resolved by Marcin Nowak
Hi @mnowak,
Trigger_athena_data-test fails because of
2021-03-08T203256 CET TrigValSteering INFO Test trig_data_v1Dev_build finished with code 1 because the following required steps failed: ['MessageCount'] ========== INFO FINISHED test_trig_data_v1Dev_build.py WITH EXIT CODE 1Can you please take a look?
Thanks, Volker (L1)
- Last reply by Marcin Nowak
added review-user-action-required label and removed review-pending-level-1 label
added 378 commits
-
1e30ff70...e1948dfb - 376 commits from branch
atlas:master - 9deb331c - Read IOV Conditions objects using dedicated PersSvc instance
- e6958d5e - Merge branch 'conditions.apr.context' of...
-
1e30ff70...e1948dfb - 376 commits from branch
-
-
This merge request affects 9 packages:
- Control/IOVSvc
- Database/APR/StorageSvc
- Database/AthenaPOOL/AthenaPoolCnvSvc
- Database/AthenaPOOL/AthenaPoolExample/AthenaPoolExampleAlgorithms
- Database/AthenaPOOL/EventSelectorAthenaPool
- Database/AthenaPOOL/PoolSvc
- Database/IOVDbSvc
- Database/PersistentDataModelAthenaPool
- Trigger/TrigValidation/TriggerTest
Affected files list will not be printed in this case
Adding @vmartin ,@okumura ,@tadej ,@ssnyder ,@mnowak as watchers
added Trigger review-pending-level-1 labels and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests 
Full details available on this CI monitor view
added review-approved label and removed review-pending-level-1 label
mentioned in commit f41ede18
added sweep:ignore label
This MR broke two unit tests. See ATEAM-718
mentioned in merge request !41536 (merged)
mentioned in commit dae7ad47