xAODEventFormatCnv: Fix handling of rejected events.

If an event is rejected for an output stream, there won't be a DataHeader made for that stream. In EventFormatStreamHelperTool, handle the case of a missing DataHeader.

This merge request affects 1 package:

• Event/xAOD/xAODEventFormatCnv

This merge request affects 1 file:

• Event/xAOD/xAODEventFormatCnv/src/EventFormatStreamHelperTool.cxx

Adding @akraszna as watcher

added EDM master review-pending-level-1 labels

CI Result SUCCESS (hash 444add30)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29559]

It's worth mentioning that this issue is causing several unit test failures in the nightly.

• http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7G8AthenaOpt/ARDOC_TestLog_2021-03-07T2101/Database_AthenaPOOL_AthenaPoolExample_AthenaPoolExampleAlgorithms___AthenaPoolExampleAlgorithmsConf__AthenaPoolExampleAlgorithmsTest__m.html
• http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7G8AthenaOpt/ARDOC_TestLog_2021-03-07T2101/AtlasTest_DatabaseTest_AthenaPoolMultiTest___AthenaPoolMultiTestConf__AthenaPoolMultiTestTest__m.html

Let me also ping @berghaus for information.

Thank you @ssnyder @akraszna. I'll look into those failures.

Hi Frank,

Do have a look. But my understanding is that this MR will fix them. So don't go and start writing code because of them... (I noticed the errors over the weekend myself, and was thinking of looking at them this morning. And then noticed that Scott already created an MR fixing them. )

Cheers, Attila

I was surprised that the database test errors didn't show in the CI of the original MR. This is not the first time Scott surprised me with a weekend commit like this

I understand this is ready to go, approving (L1).

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 3337966c

mentioned in merge request !41340 (merged)

added sweep:ignore label

mentioned in merge request !41059 (merged)