Skip to content
Snippets Groups Projects

Egamma ART: adding histograms for more detailed checks of conversion reconstruction performance

Merged Egamma ART: adding histograms for more detailed checks of conversion reconstruction performance
ktackman/athena:NewConvHistos into master
All threads resolved!
Merged Kerstin Tackmann requested to merge ktackman/athena:NewConvHistos into master
All threads resolved!

Egamma ART: adding histograms for more detailed checks of conversion reconstruction performance: efficiency vs mu, plots for fake conversions, plots for track properties. Tagging @dboerner

Edited by Kerstin Tackmann

Merge request reports

Pipeline #2406735 passed

Stage: external

    Pipeline passed for 0d71c956 on ktackman:NewConvHistos

    Approval is optional

    Merged by Edward MoyseEdward Moyse 4 years ago (Mar 17, 2021 4:44pm UTC)

    Merge details

    • Changes merged into master with fb401c51 (commits were squashed).
    • Did not delete the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Kerstin Tackmann added alsoTargeting:21.0 label

      added alsoTargeting:21.0 label

    • Christos Anastopoulos
      Christos Anastopoulos @christos ·
      Developer

      Jenkins please retry a build

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • Reconstruction/egamma/egammaValidation

      This merge request affects 10 files:

      • Reconstruction/egamma/egammaValidation/scripts/EgammaARTmonitoring_plotsMaker.py
      • Reconstruction/egamma/egammaValidation/src/EgammaMonitoring.cxx
      • Reconstruction/egamma/egammaValidation/src/EgammaMonitoring.h
      • Reconstruction/egamma/egammaValidation/src/IHistograms.h
      • Reconstruction/egamma/egammaValidation/src/ParticleHistograms.cxx
      • Reconstruction/egamma/egammaValidation/src/ParticleHistograms.h
      • Reconstruction/egamma/egammaValidation/src/TrackHistograms.cxx
      • Reconstruction/egamma/egammaValidation/src/TrackHistograms.h
      • Reconstruction/egamma/egammaValidation/src/TruthPhotonHistograms.cxx
      • Reconstruction/egamma/egammaValidation/src/TruthPhotonHistograms.h

      Adding @goetz as watcher

    • ATLAS Robot added Egamma Reconstruction master labels

      added Egamma Reconstruction master labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash 8374e937)

      Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :warning: Athena: number of compilation errors 0, warnings 1
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
      :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29896]

    • Kerstin Tackmann removed alsoTargeting:21.0 label

      removed alsoTargeting:21.0 label

    • Kerstin Tackmann added 1 commit

      added 1 commit

      • f6a54ffc - Fixing the unused variable compilation warning.

      Compare with previous version

    • Kerstin Tackmann marked this merge request as ready

      marked this merge request as ready

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • Reconstruction/egamma/egammaValidation

      This merge request affects 10 files:

      • Reconstruction/egamma/egammaValidation/scripts/EgammaARTmonitoring_plotsMaker.py
      • Reconstruction/egamma/egammaValidation/src/EgammaMonitoring.cxx
      • Reconstruction/egamma/egammaValidation/src/EgammaMonitoring.h
      • Reconstruction/egamma/egammaValidation/src/IHistograms.h
      • Reconstruction/egamma/egammaValidation/src/ParticleHistograms.cxx
      • Reconstruction/egamma/egammaValidation/src/ParticleHistograms.h
      • Reconstruction/egamma/egammaValidation/src/TrackHistograms.cxx
      • Reconstruction/egamma/egammaValidation/src/TrackHistograms.h
      • Reconstruction/egamma/egammaValidation/src/TruthPhotonHistograms.cxx
      • Reconstruction/egamma/egammaValidation/src/TruthPhotonHistograms.h

      Adding @goetz as watcher

    • ATLAS Robot added review-pending-level-1 label

      added review-pending-level-1 label

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash f6a54ffc)

      Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
      :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29966]

  • T
    Thomas James Neep @tneep ·

    Generally looks good to me, just three minor style comments if you have the time to implement them. Tom - L1 shifter

  • Thomas James Neep added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Kerstin Tackmann added 1 commit

    added 1 commit

    • 0d71c956 - Addressing comments from review.

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Reconstruction/egamma/egammaValidation

    This merge request affects 10 files:

    • Reconstruction/egamma/egammaValidation/scripts/EgammaARTmonitoring_plotsMaker.py
    • Reconstruction/egamma/egammaValidation/src/EgammaMonitoring.cxx
    • Reconstruction/egamma/egammaValidation/src/EgammaMonitoring.h
    • Reconstruction/egamma/egammaValidation/src/IHistograms.h
    • Reconstruction/egamma/egammaValidation/src/ParticleHistograms.cxx
    • Reconstruction/egamma/egammaValidation/src/ParticleHistograms.h
    • Reconstruction/egamma/egammaValidation/src/TrackHistograms.cxx
    • Reconstruction/egamma/egammaValidation/src/TrackHistograms.h
    • Reconstruction/egamma/egammaValidation/src/TruthPhotonHistograms.cxx
    • Reconstruction/egamma/egammaValidation/src/TruthPhotonHistograms.h

    Adding @goetz as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 0d71c956)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30079]

  • Thomas James Neep resolved all threads

    resolved all threads

  • Thomas James Neep added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit fb401c51

    mentioned in commit fb401c51

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Daniela Kuchler mentioned in merge request !42530 (merged)

    mentioned in merge request !42530 (merged)

    • Please register or sign in to reply