Remove ConfigFlags.Detector.SimulateXXX completely

After !41259 (merged) removed all usage of the Detector.Simulate ConfigFlags, it is now safe from them to be removed.
Doing so also makes the temporarily introduced SimulationTestHelpers module obsolete, so this is removed as well and replaced with sytnax added in !41441 (merged).
FYI @tadej, @dnoel, @bleban, @emoyse

added NewConfig label

added 45 commits

• 295ffd6f...15c174ff - 38 commits from branch atlas:master
• e3e98920 - Replace use of ConfigFlags.Detector.SimulateXXX
• 89ac7aae - Use ConfigFlags.Detector.Enable to configure hit collection writing
• d47df872 - Use Common configuration for StreamHITS ItemList
• 64113aa6 - Drop unneeded extra configuration on TileGeoG4SDCalc
• d8a8999d - Remove ConfigFlags.Detector.SimulateXXX
• 053cfbf4 - Switch to using AutoConfigFlags.getDefaultDetectors method in Simulation configuration
• 3692bd87 - Drop obsolete SimulationTestHelpers module

Compare with previous version

Maybe don't wait for !41271 (merged) if this one is ready? I'm still fighting that dragon, and I suspect another round of CI is on the cards anyway... fixing some merge conflicts isn't that big a deal.

added 87 commits

• 3692bd87...16146ffa - 84 commits from branch atlas:master
• 71380b3a - Remove ConfigFlags.Detector.SimulateXXX
• 966b64f3 - Switch to using AutoConfigFlags.getDefaultDetectors method in Simulation configuration
• f76aff07 - Drop obsolete SimulationTestHelpers module

Compare with previous version

resolved all threads

marked this merge request as ready

changed the description

This merge request affects 8 packages:

• Control/AthenaConfiguration
• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasServices
• Simulation/G4Atlas/G4AtlasTools
• Simulation/ISF/ISF_Config
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
• Simulation/SimuJobTransforms

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc ,@ssnyder as watchers

added Core Simulation master review-pending-level-1 labels

CI Result FAILURE (hash f76aff07)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29886]

added 29 commits

• f76aff07...0f3be21f - 26 commits from branch atlas:master
• 29bbf98d - Remove ConfigFlags.Detector.SimulateXXX
• ac6ecddd - Switch to using AutoConfigFlags.getDefaultDetectors method in Simulation configuration
• c2944f56 - Drop obsolete SimulationTestHelpers module

Compare with previous version

This merge request affects 8 packages:

• Control/AthenaConfiguration
• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasServices
• Simulation/G4Atlas/G4AtlasTools
• Simulation/ISF/ISF_Config
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
• Simulation/SimuJobTransforms

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc ,@ssnyder as watchers

CI Result SUCCESS (hash c2944f56)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29911]

Approving as expert to avoid conflicts.

added review-approved label and removed review-pending-level-1 label

mentioned in commit 462c91dc

merged

added sweep:ignore label