ATR-23011 -- Type-checking of "flags" argument to RecoFragmentsPool.retrieve

The first argument for any function passed to RecoFragmentsPool.retrieve is supposed to be an AthConfigFlags instance. As this is meant to be unique for the whole job, it is not part of the key to the cache of return values held by RecoFragmentsPool.

There were examples of misuse whereby important and malleable arguments to these functions were being passed instead, which could cause misconfiguration. To prevent this, insist that the value of the first (and only non-keyword) argument received is either an instance of ConfigFlags or is None. The latter should be used when there is no information that is used from ConfigFlags.

Various fixes needed to be propagated to signature code such that this will not result in crashes.

changed title from WIP: Type-checking of "flags" argument to RecoFragmentsPool.retrieve to WIP: ATR-23011 -- Type-checking of "flags" argument to RecoFragmentsPool.retrieve

added 783 commits

• 2874f725...bfd478fc - 778 commits from branch atlas:master
• 443e062e - Enforce type-checking in RecoFragmentsPool.retrieve
• ebe03b4b - Correct TLA config to correctly pass flags to RecoFragmentsPool
• 83634de1 - Add flags slot to tau and HLTCalo sequence generators
• 4b3a7ec4 - ConfigFlags argument for calo reco sequences
• efee9982 - Fix JetDefinition hash fn

Compare with previous version

I believe I have this working. As I needed to make changes in the signature code for a few signatures, I'd like to request that the experts sign off. Tagging the coordinators, please feel free to add other relevant developers.

Egamma: @cjmeyer, @fernando Tau: @ademaria, @malconad MET: @jburr, @bcarlson HLTCalo: @joheinri, @damazio

marked this merge request as ready

changed the description

This merge request affects 4 packages:

• Reconstruction/Jet/JetRecConfig
• Trigger/TrigAlgorithms/TrigGenericAlgs
• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @goetz ,@sutt ,@joheinri ,@dbakshig ,@jburr ,@damazio ,@khamano ,@fernando ,@bernius ,@bcarlson ,@hrussell ,@ademaria ,@malconad ,@cjmeyer ,@carquin ,@dzanzi as watchers

added Egamma JetEtmiss Reconstruction Tau Trigger TriggerMenu master review-pending-level-1 labels

Also FYI @doglioni -- see changes to make TLA seq config conform in case this is used as a reference for any other TLA setups.

CI Result SUCCESS (hash efee9982)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30623]

Hi,

this looks fine from L1 side, setting review-pending-expert, so the relevant experts tagged above can comment.

Cheers, Volker (L1)

added review-pending-expert label and removed review-pending-level-1 label

Looks fine from my end, I only looked through the MET-related changes in detail but the others looked OK from a cursory glance.

resolved all threads

added review-approved label and removed review-pending-expert label

Given that the period for feedback expired, I'm declaring this reviewed by experts, so setting the approved label based on @vaustrup's sign-off. Hope there are no objections.

merged

mentioned in commit cfef66cb

added sweep:ignore label