TrigT1RPChardware+TrigT1RPClogic: thread checker fixes

Fixes (mostly const) for thread checker in TrigT1RPChardware and TrigT1RPClogic.

Also in this MR:

• Add package name to include guard.
• Enable thread-checker for several other trigger packages that did not need any fixes.

This merge request affects 10 packages:

• Trigger/TrigHypothesis/TrigHypoCommonTools
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEXToolInterfaces
• Trigger/TrigT1/TGCTriggerCondSvc
• Trigger/TrigT1/TrigT1CaloFexPerf
• Trigger/TrigT1/TrigT1Monitoring
• Trigger/TrigT1/TrigT1MuctpiBits
• Trigger/TrigT1/TrigT1MuonRecRoiTool
• Trigger/TrigT1/TrigT1RPChardware
• Trigger/TrigT1/TrigT1RPClogic

Affected files list will not be printed in this case

Adding @bcarlson ,@junpei ,@kwhalen ,@damazio ,@afaulkne as watchers

added DQ Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 05a64171)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29940]

removed review-pending-level-1 label

added review-user-action-required label

added 2 commits

• 38596d2c - TrigT1RPChardware: add package name to include guards
• f8b54a39 - TrigT1RPClogic: enable thread-checker and fixes

Compare with previous version

resolved all threads

This merge request affects 10 packages:

• Trigger/TrigHypothesis/TrigHypoCommonTools
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEXToolInterfaces
• Trigger/TrigT1/TGCTriggerCondSvc
• Trigger/TrigT1/TrigT1CaloFexPerf
• Trigger/TrigT1/TrigT1Monitoring
• Trigger/TrigT1/TrigT1MuctpiBits
• Trigger/TrigT1/TrigT1MuonRecRoiTool
• Trigger/TrigT1/TrigT1RPChardware
• Trigger/TrigT1/TrigT1RPClogic

Affected files list will not be printed in this case

Adding @bcarlson ,@junpei ,@kwhalen ,@damazio ,@afaulkne as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash f8b54a39)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29965]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit b200b716

added sweep:ignore label

Hi @fwinkl - it seems like we have a compilation warning now in TrigT1CaloFexPerf which I assume is related? http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7G8AthenaOpt/ARDOC_Log_2021-03-16T2101/Trigger_TrigT1_TrigT1CaloFexPerf.html

Yep, interference between this and !41450 (merged). Fixed in !41685 (merged).

mentioned in merge request !41685 (merged)

added Run3L1Calo label