TrkExTools: Fix cppcheck warnings.

Remove redundant comparisons.

This merge request affects 1 package:

• Tracking/TrkExtrapolation/TrkExTools

This merge request affects 1 file:

• Tracking/TrkExtrapolation/TrkExTools/src/MaterialEffectsUpdator.cxx

Adding @amorley as watcher

added Tracking master review-pending-level-1 labels

CI Result SUCCESS (hash 950e08d8)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30093]

Sending to L2 as I'm a little unsure about this. I get the removal of the redundant if (mpars) checks, but I'm unsure about the (m_validationMode && !m_validationIgnoreUnmeasured) part. I'm probably missing something obvious about why that can be removed. Tom - L1 shifter

added review-pending-level-2 label and removed review-pending-level-1 label

This change of course does not change the function of the code at all (mpars must be non-null because it was dereferenced, so (mpars||X) is redundant for any X), but perhaps the original code was buggy. (Was && meant instead of ||?)

resolved all threads

added review-pending-level-1 label and removed review-pending-level-2 label

Changes look fine, tests pass, threads resolved. L1 approving.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 1097a24a

added sweep:ignore label