Add adaptive vertexing to the tau slice

Add the adaptive vertexing to the tau slice, using a vertex collection HLT_IDVertex_Tau

marked this merge request as draft

marked this merge request as ready

marked this merge request as draft

This merge request affects 3 packages:

• Trigger/TrigTools/TrigInDetConfig
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@cvarni ,@nagano ,@carquin ,@mvozak ,@amorley ,@bernius ,@hrussell ,@okuprash ,@ademaria ,@suyogs ,@malconad ,@sekula as watchers

added JetEtmiss Tau Trigger TriggerEDM TriggerID TriggerMenu master review-pending-level-1 labels

CI Result FAILURE (hash 3acedcfa)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30099]

Helpful CI test output ...

INFO     Running patched in rel 
INFO     "Sim_tf.py --AMIConfig s3505 --inputEVNTFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/SimCoreTests/ttbar_muplusjets-pythia6-7000.evgen.pool.root --outputHITSFile myHITS.pool.root --imf False  --maxEvents=10 "
INFO     Finished patched in rel 
INFO     "Sim_tf.py --AMIConfig s3505 --inputEVNTFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/SimCoreTests/ttbar_muplusjets-pythia6-7000.evgen.pool.root --outputHITSFile myHITS.pool.root --imf False  --maxEvents=10 "
INFO     -----------------------------------------------------
INFO     ----------- Post-processing of s3505 Test -----------
INFO     -----------------------------------------------------
INFO     Did each step of the s3505 test complete successfully?
INFO     
ERROR    EVNTtoHITS Patched test failed
INFO     
ERROR    One or more s3505 Athena steps failed. Please investigate the cause.
INFO     -----------------------------------------------------
INFO     ---------------------- Summary ----------------------
ERROR    ALL TESTS: FAILED (-1)
==================END SimulationTier0Test with exit codes: 255 Wed Mar 17 11:52:42 CET 2021

grepping errors in run_s3505/log.EVNTtoHITS
grep: run_s3505/log.EVNTtoHITS: No such file or directory

Once lockdown has finished, I will buy a beer for anyone who can identify why this test actually failed just from the log file. EVNTtoHITS would be before the RDOtoRDOTrigger, which is where my changes would matter, and not before.

removing L1 label while WIP/Draft.

removed review-pending-level-1 label

Hello @sutt, sorry to chime in but isn't this the failure from AthSimulation? Not sure this what's going on but latest MR are not suffering from AthSimulation errors so it should have been a temporary problem. I also tried to import your changes in a clean version of the master and the data quality test is failing with :

RDOtoRDOTrigger 12:03:44 EDMCreatorAlg 0 0 FATAL Standard std::exception is caught RDOtoRDOTrigger 12:03:44 EDMCreatorAlg 0 0 ERROR SG::ExcNullReadHandle: Dereference of read handle failed: IMFTFId_view_0+HLT_IDVertex_Tau[1092961325] RDOtoRDOTrigger 12:03:44 AlgTask 0 0 FATAL .executeEvent(): Standard std::exception thrown by EDMCreatorAlg RDOtoRDOTrigger 12:03:44 AlgTask 0 0 ERROR SG::ExcNullReadHandle: Dereference of read handle failed: IMFTFId_view_0+HLT_IDVertex_Tau[1092961325]

Many thanks Antonio, I am still trying to get the changes to work. Once that is resolved, I will remove the WIP.

Cheers Mark

added 1 commit

• b10d0dff - Fix Tau vertex

Compare with previous version

marked this merge request as ready

marked this merge request as draft

WARNING: precompile check possibly found BANNED WORDS in the changeset. Please check to make sure they are acceptable (and conform to the CERN code of conduct) before proceeding with this MR

location of these words provided by git-keywords.lines.sh

Trigger/TrigTools/TrigInDetConfig/python/InDetPT.py: 113 149 151 161 ; Trigger/TrigTools/TrigInDetConfig/python/TrigInDetPriVtxConfig.py: 69 ;

end of git-keywords.lines.sh output

This merge request affects 3 packages:

• Trigger/TrigTools/TrigInDetConfig
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@cvarni ,@nagano ,@carquin ,@mvozak ,@amorley ,@bernius ,@hrussell ,@okuprash ,@ademaria ,@suyogs ,@malconad ,@sekula as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash b10d0dff)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30677]

added 1 commit

• 00523255 - remove printout

Compare with previous version

marked this merge request as ready