Skip to content
Snippets Groups Projects

use PathResolver to find G4particle_whitelist.txt, add missing dependency in...

Merged Ewelina Maria Lobodzinska requested to merge ewelina/athena:mster-md into master
All threads resolved!

use PathResolver to find G4particle_whitelist.txt, add missing dependency in AthGeneration/package_filters.txt - to avoid errors when reading MetaData info

Merge request reports

Pipeline #2426836 passed

Pipeline passed for 2341a34f on ewelina:mster-md

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 4 years ago (Mar 23, 2021 6:57pm UTC)

Merge details

  • Changes merged into master with 65bfd49d (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • None of my recommendations are super important, but if possible, making them could still be nice. (I just wanted the CMake change to be made, but then decided that I might as well comment about all other aspects of the MR as well. :stuck_out_tongue:)

  • added 1 commit

    • 2341a34f - introduce corrections requested by Attils

    Compare with previous version

  • This merge request affects 2 packages:

    • Generators/EvgenProdTools
    • Projects/AthGeneration

    Affected files list will not be printed in this case

    Adding @akraszna as watcher

  • :white_check_mark: CI Result SUCCESS (hash 2341a34f)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30482]

  • Attila Krasznahorkay resolved all threads

    resolved all threads

  • mentioned in commit 65bfd49d

  • Please register or sign in to reply
    Loading