Read outer radius from DB for Upgrade
It has been observed that up to now we have been taking the IDET outer radius from a hard-coded python value (while the inner radius was updated to be read from the geometry DB some time back). It is not clear why this is the case (also for the current detector) since there has been a parameter for this available in the DB for some time.
This becomes a problem because the hard-coded outer radius is slightly smaller than the outer radius of the polymoderator in new designs, and so we would like to expand the IDET envelope in order to fit it without clashes, via updating this parameter in the geometry tag.
This MR does that, and seems to work as anticipated:
DetectorGeometr... INFO CylindricalEnvelope::BuildGeometry(): (Inner Radius, Outer Radius, dZ) = (28.5, 1147.8, 3545)However, the value in the DB for older geometry tags is slightly smaller than the hardcoded one (1147.8 vs 1148.0), and so this changes the simulation output for older tags. Hopefully this is just very small effect on the amount of air in the volume, and nothing more significant. Therefore it is not clear if it is worthwhile to add some complicated version checking in this code to protect old geometries.
Keeping in Draft while opinions are sought (and perhaps some testing done).