Make combined algorithms reentrant
addresses ATLASRECTS-6209
Merge request reports
Activity
added 2 commits
mentioned in merge request !42388 (merged)
added 50 commits
-
ded39a0b...e0f9b099 - 48 commits from branch
atlas:master - ecb5f6ec - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into Combined_Reenntrant
- 7734dab0 - First migration towards reentrant
-
ded39a0b...e0f9b099 - 48 commits from branch
added 9 commits
-
f3298657 - 1 commit from branch
atlas:master - 4fba02f2 - Reindentation of MuidInterfaces
- 73046f24 - Reindent MuonCombinedBaseTools
- edc2be5f - Reindent Muon combined algs
- a77f24ed - Reindent MuonCombinedToolInterfaces
- 047ffc5a - Emplace unique_ptrs
- 9210432a - First migration towards reentrant
- 6f09ff7b - Reindentation of MuonCombinedToolInterfaces
- 72538771 - Merge branch 'CombinedReentrant_volII' of...
Toggle commit list-
f3298657 - 1 commit from branch
added 1 commit
- b5c06ff3 - Reindentation of the MuidTrackBuilder package
added 56 commits
-
f6cd9568...3df8816f - 53 commits from branch
atlas:master - e8c64a83 - Reindentation of the MuidTrackBuilder package
- c6a850ea - Fix merge conflict
- a41143d9 - Fix merge conflict again
Toggle commit list-
f6cd9568...3df8816f - 53 commits from branch
added 10 commits
-
a41143d9...e00224fb - 8 commits from branch
atlas:master - f2eaa8ad - Remove PACKAGE_VERSION
- 8f326431 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into Combined_Reenntrant
-
a41143d9...e00224fb - 8 commits from branch
added 1 commit
- c86de127 - Move the OutwardsCombinedTrackBuilder to reentrant
added 4 commits
-
c86de127...d90444e3 - 2 commits from branch
atlas:master - 6b4b0c56 - Make missing fit method reentrant
- 686a1fa2 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into Combined_Reenntrant
-
c86de127...d90444e3 - 2 commits from branch
This merge request affects 5 packages:
- Reconstruction/MuonIdentification/MuidInterfaces
- Reconstruction/MuonIdentification/MuidTrackBuilder
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
Affected files list will not be printed in this case
added Reconstruction Trigger master review-pending-level-1 labels
removed review-pending-level-1 label
Resolved by Johannes JunggeburthHi could you consider adding
https://twiki.cern.ch/twiki/bin/view/AtlasComputing/CheckerGccPlugins#thread_plugin
An entire directory tree may be marked for checking by creating a (empty) file at the root of the tree with the name ATLAS_CHECK_THREAD_SAFETY. For a package, this file may also be placed in the include directory. This is recommended for packages that have an include directory, since in that case the file will be visible in an installed release.
Since the idea is actually to make code re-entrant this should be prb be there so as the code to be checked by default.
As it will be an issue if it claims to be safe and does not pass this ...
Edited by Christos Anastopoulos- Last reply by Louis-Guillaume Gagnon
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals 
cmake make 
required tests optional tests 
Full details available on this CI monitor view
added 27 commits
-
686a1fa2...4cca1942 - 22 commits from branch
atlas:master - 0a7523ec - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into Combined_Reenntrant
- 1483490c - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into Combined_Reenntrant
- 1fa4b908 - Indentation fixes
- 674e7d03 - Reindentation of MuonTrackFinderTools
- 4b9ec49b - Reindentation of MuonRecToolInterfaces
Toggle commit list-
686a1fa2...4cca1942 - 22 commits from branch
