Draft: DIRE and VINCIA Base Fragments for Pythia 8.3

Added Pythia8_Dire_Base_Fragment.py and Pythia8_Vincia_Base_Fragment.py (two new shower modes of Pythia 8.3) to Pythia8_i/share/common.

Tagging @cgutscho @ewelina @gpanizzo

This merge request affects 1 package:

• Generators/Pythia8_i

This merge request affects 2 files:

• Generators/Pythia8_i/share/common/Pythia8_Dire_Base_Fragment.py
• Generators/Pythia8_i/share/common/Pythia8_Vincia_Base_Fragment.py

added Generators master review-pending-level-1 labels

marked this merge request as draft

Hi @marvin - thanks for this. I'm making it WIP, as I have a few questions:

• Shouldn't this go into 21.6 first of all?
• Why does the DIRE one only contain one line (is that really sufficient?) and the VINCIA one has 35 lines with most of them commented out?
• Shouldn't the DIRE/Vincia base fragment also include one of the common fragments, so that the user only needs to include one fragment rather than several in a chain?

CI Result SUCCESS (hash 0c1c6980)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31392]

Changing the automatically added labels as this is not ready for MR review.

Cheers, Martin (L1)

added review-user-action-required label and removed review-pending-level-1 label

@marvin can you please add the ATLAS robot as a developer member of your fork? https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot

cheers, -- L1

changed target branch from master to 21.6

@mhabedan I think for WIP/draft MR's we don't even want the review-user-action-required label, as otherwise it shows up in the "MR problems" summary page. Removing it for now -- L1

removed review-user-action-required label

The branch should have been made off of 21.6, as that's where the includes should go. Closing.

closed