Skip to content
Snippets Groups Projects

WIP: ATR-23160 - Check consistency between L1 thresholds and HLT signatures

Closed WIP: ATR-23160 - Check consistency between L1 thresholds and HLT signatures
lidiaz/athena:TM_ATR-23160 into master
3 unresolved threads
Closed Lidija Zivkovic requested to merge lidiaz/athena:TM_ATR-23160 into master
3 unresolved threads

To check that always right L1 is used

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Muon/generateMuon.py
523 523 for part in chainDict['chainParts']:
524 524 l1Thresholds.append(part['L1threshold'])
525 525
526 if 'noL1' in chainDict['chainName']:
527 if 'FSNOSEED' not in l1Thresholds:
528 log.error("Muon noL1 chain should be seeded from FSNOSEED...")
529 raise Exception("Muon noL1 chain should be seeded from FSNOSEED...")
530
531 if 'noL1' not in chainDict['chainName']:
  • Teng Jian Khoo
    Teng Jian Khoo @khoo ·
    Developer

    I guess this can just be an else. Also the 2nd exception has the same message as the upper one. Should maybe say "Standard muon chain", something like that. That aside I think this is indeed what was intended. So from my side, happy if you go ahead, then we can iterate with signature coords and menu experts to see if all the cases are covered.

  • Lidija Zivkovic
    Lidija Zivkovic @lidiaz ·
    Author Developer

    Hi, "else" was complaining about indent, and all was positioned at the same place :). I will check once more.

    I will also fix error messages and let you know when I have it for other chains.

    Lidija

  • Lidija Zivkovic changed this line in version 3 of the diff

    changed this line in version 3 of the diff

  • Lidija Zivkovic
    Lidija Zivkovic @lidiaz ·
    Author Developer

    Hi @khoo

    I am failing one ctest, unitTestRun_generateMenuMT_newJO, but, others, including unitTestRun_generateMenuMT are passing, which is strange. I put some printouts in error message, and I am not sure why am I failing: Py:TriggerMenuMT.HLTMenuConfig.Muon.generateMuon ERROR Standard muon chain should be seeded from L1_MU. Check HLT_mu20_L1MU20, l1 threshold ['MU20']

    Whole traceback is below.

    Lidija

    Traceback (most recent call last): File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3_ATLAS_8/Python/3.7.6/x86_64-centos7-gcc8-opt/lib/python3.7/runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3_ATLAS_8/Python/3.7.6/x86_64-centos7-gcc8-opt/lib/python3.7/runpy.py", line 85, in _run_code exec(code, run_globals) File "/afs/cern.ch/user/l/lidiaz/workspace/xAODTriggerWork/FulGitNew/build/x86_64-centos7-gcc8-opt/python/TriggerMenuMT/HLTMenuConfig/Menu/LS2_v1_newJO.py", line 127, in <module> menu = generateMenu( ConfigFlags) File "/afs/cern.ch/user/l/lidiaz/workspace/xAODTriggerWork/FulGitNew/build/x86_64-centos7-gcc8-opt/python/TriggerMenuMT/HLTMenuConfig/Menu/GenerateMenuMT_newJO.py", line 166, in generateMenu loadChains(flags) File "/afs/cern.ch/user/l/lidiaz/workspace/xAODTriggerWork/FulGitNew/build/x86_64-centos7-gcc8-opt/python/TriggerMenuMT/HLTMenuConfig/Menu/GenerateMenuMT_newJO.py", line 156, in loadChains listDictsAndConfigs.append(generateChainConfig(flags, chain, sigGenMap)) File "/afs/cern.ch/user/l/lidiaz/workspace/xAODTriggerWork/FulGitNew/build/x86_64-centos7-gcc8-opt/python/TriggerMenuMT/HLTMenuConfig/Menu/GenerateMenuMT_newJO.py", line 84, in generateChainConfig chainConfig = sigGenMap[signature](flags, chainDict) File "/afs/cern.ch/user/l/lidiaz/workspace/xAODTriggerWork/FulGitNew/build/x86_64-centos7-gcc8-opt/python/TriggerMenuMT/HLTMenuConfig/Muon/generateMuon.py", line 534, in generateChains raise Exception("Standrad muon chain should be seeded from L1_MU...") Exception: Standrad muon chain should be seeded from L1_MU...

  • Please register or sign in to reply
  • Lidija Zivkovic added 152 commits

    added 152 commits

    Compare with previous version

  • Lidija Zivkovic added 1 commit

    added 1 commit

    Compare with previous version

  • Lidija Zivkovic added 673 commits

    added 673 commits

    Compare with previous version

    Toggle commit list
  • Lidija Zivkovic
    Lidija Zivkovic @lidiaz ·
    Author Developer

    So it is working. I added this chains in separate trials: ChainProp(name='HLT_mu8_mu8noL1_L1MU6', l1SeedThresholds=['FSNOSEED','FSNOSEED'], groups=MultiMuonGroup), ChainProp(name='HLT_mu8_mu8noL1_L1MU6', l1SeedThresholds=['MU6','MU6'], groups=MultiMuonGroup), ChainProp(name='HLT_mu10_lateMu_L1LATE-MU10_XE50', l1SeedThresholds=['MU6'], groups=SingleMuonGroup),

    and each of them crashed graciously.

    I will proceed with other signatures and let you know once I am ready.

    Lidija

  • Lidija Zivkovic added 1 commit

    added 1 commit

    Compare with previous version

  • Lidija Zivkovic added 1 commit

    added 1 commit

    Compare with previous version

  • Lidija Zivkovic
    Lidija Zivkovic @lidiaz ·
    Author Developer

    Hi @khoo, @markowen and @dzanzi,

    can you please check it now. Some exceptions are commented out since it is not true for all chains in those groups.

    Lidija

  • Teng Jian Khoo
  • Lidija Zivkovic added 196 commits

    added 196 commits

    Compare with previous version

  • Daniele Zanzi
    Daniele Zanzi @dzanzi started a thread on the diff
    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/DictFromChainName.py
    63 63 l1seedlist = getSpecificL1Seeds(l1seed, itemsDict)
    64 64 return l1seedlist
    65 65
    66 log.info("Lidija je ovde: chain %s, l1seed %s", chainName, l1seed )
  • Daniele Zanzi
    Daniele Zanzi @dzanzi started a thread on an old version of the diff
    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/DictFromChainName.py
    559 if thisSignature in ['Electron','Photon']:
    560 if 'EM' not in thisL1:
    561 log.error("Standard egamma chains should be seeded from L1_EM. Check %s, l1 threshold %s",chainDict['chainName'],l1Thresholds)
    562 raise Exception("Standrad egamma chain should be seeded from L1_EM...")
    563
    564 if thisSignature in 'Tau':
    565 if 'TAU' not in thisL1:
    566 log.error("Standard tau chains should be seeded from L1_TAU. Check %s, l1 threshold %s",chainDict['chainName'],l1Thresholds)
    567 raise Exception("Standrad tau chain should be seeded from L1_TAU...")
    568
    569 if thisSignature in ['Jet','Bjet','MET','UnconventionalTracking']:
    570 if 'FSNOSEED' not in thisL1:
    571 log.error("Jet, b-jet, MET chains should be seeded from FSNOSEED. Check %s, l1 threshold %s",chainDict['chainName'],l1Thresholds)
    572 # raise Exception("Jet, b-jet, MET chain should be seeded from FSNOSEED...")
    573
    574 if thisSignature in ['Beamspot','Streaming','EnhancedBias','Monitor','Calib','MinBias']:
  • Lidija Zivkovic added 1866 commits

    added 1866 commits

    Compare with previous version

  • Lidija Zivkovic added 1657 commits

    added 1657 commits

    Compare with previous version

    Toggle commit list
  • Lidija Zivkovic added 3 commits

    added 3 commits

    Compare with previous version

  • Lidija Zivkovic added 1 commit

    added 1 commit

    Compare with previous version

  • Lidija Zivkovic added 823 commits

    added 823 commits

    Compare with previous version

    Toggle commit list
  • V
    Volker Andreas Austrup @vaustrup ·
    Developer

    Closing after three months of inactivity, as per the shifter rules. -L1

  • Volker Andreas Austrup closed

    closed

  • Daniele Zanzi
    Daniele Zanzi @dzanzi ·

    @lidiaz can you make a new MR?

  • Lidija Zivkovic
    Lidija Zivkovic @lidiaz ·
    Author Developer

    @dzanzi I will when I have some progress.

    • Please register or sign in to reply