JetRec: Check input file for tracks/vertices
This updates the jet configuration to check the input file as well as the transient store for the the standard track and vertex collections when setting configuration flags. Previously it checked only the transient store - somehow this has been the case for at least 6 years without causing any serious problems. Recently, derivations such as PHYS have required a preExec manually setting some detector flags to run without crashing, and upon investigating I found this to be the culprit.
So, this should remove the need for the "magic preExec" when running derivations. I've tested that PHYS runs successfully out of the box with this change.
Tagging @sawyer, @mswiatlo, @cdelitzs, @zmarshal, as well as @ligang who recently ran into this.
Also @jferrand and @miochoa might be interested since they've been requesting quite a few r22 DAODs for the physics validation effort.
Merge request reports
Activity
That's correct, the function I'm using here now checks both the input file and the transient store for existing tracks and vertices. The check for whether they will be made (in the same job, e.g. RAWtoALL) happens just below that one and is already correct as far as I'm aware. Further down we take an "or" of these two checks to decide whether we'll ultimately have tracks/vertices. That's why we've only been running into issues when using input files that already contain these.
-Bill
This merge request affects 1 package:
- Reconstruction/Jet/JetRec
This merge request affects 1 file:
- Reconstruction/Jet/JetRec/python/JetRecStandard.py
Adding @goetz as watcher
added JetEtmiss Reconstruction master review-pending-level-1 labels
CI Result SUCCESS (hash 71995a9e)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31603]added review-approved label and removed review-pending-level-1 label
mentioned in commit eaf8208b
added sweep:ignore label