Skip to content
Snippets Groups Projects

new methods for the file storage added

Merged Mikhail Mineev requested to merge mmineev/athena:22.0-mvg-02 into master

New features:

  1. added new methods for the file storage (for global tags, global tag maps, tag meta info).
  2. the library methods are splitted. The class CrestClientExt (CrestApiExt.h) extends CrestClient and contains all methods which use the Boost Parameter library.
  3. the methods for the tag meta info are updated.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @mmineev,

    two small comments from L1 side. Can you please take a look?

    Thanks, Volker (L1)

  • Mikhail Mineev added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    Thank you for the comments. I hope I corrected it.

    Mikhail

  • This merge request affects 1 package:

    • Database/CrestApi

    This merge request affects 5 files:

    • Database/CrestApi/CrestApi/CrestApi.h
    • Database/CrestApi/CrestApi/CrestApiExt.h
    • Database/CrestApi/doc/crest_example.cxx
    • Database/CrestApi/doc/crest_example2.cxx
    • Database/CrestApi/src/CrestApi.cxx

    Adding @ssnyder as watcher

  • :negative_squared_cross_mark: CI Result FAILURE (hash ea5aed6e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31764]

  • Pienpen Seema resolved all threads

    resolved all threads

  • The failure in the Trigger_athena_MC-test seems unrelated, I will give it one more try. Pienpen(L1)

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Database/CrestApi

    This merge request affects 5 files:

    • Database/CrestApi/CrestApi/CrestApi.h
    • Database/CrestApi/CrestApi/CrestApiExt.h
    • Database/CrestApi/doc/crest_example.cxx
    • Database/CrestApi/doc/crest_example2.cxx
    • Database/CrestApi/src/CrestApi.cxx

    Adding @ssnyder as watcher

  • :white_check_mark: CI Result SUCCESS (hash ea5aed6e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31832]

  • That was apparently the right call, CI succeeded now. Approving as all threads are resolved.

    Cheers, Martin (L1)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading