BugFix on DeXTer variable transformation

This fixes the bug that variable transformation was not applied on track pT fraction relative to jets.

added 21.2 label

This merge request affects 1 package:

• Reconstruction/Jet/BoostedJetTaggers

This merge request affects 1 file:

• Reconstruction/Jet/BoostedJetTaggers/Root/DeepsetXbbTagger.cxx

Adding @goetz ,@cdelitzs ,@meehan ,@sschramm ,@rnewhous ,@jveatch ,@mleblanc as watchers

added JetEtmiss Reconstruction review-pending-level-1 labels

Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

• Developers and shifters need to wait for both results, sometimes for additional hour or two.

CI Result SUCCESS (hash 999c8907)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31695]

CI Result SUCCESS (hash 999c8907)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 17
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 706]

added review-approved label and removed review-pending-level-1 label

added bugfix label

Hi! The code change is trivial and looks good, but could somebody among the watchers confirm that std::log(track pT/jet pT) (i.e. natural log) is the proper transformation of this input variable for the tagger?

Thanks, Giovanni (AR shifter)

added review-pending-expert label and removed review-approved label

Hi @gmarchio,

Yes, this is a bug we noticed recently. We have done a few extra validations to confirm this is the correct transformation compared with the input used in Keras training.

Thanks, Yuan-Tang (Main Developer of DeXTer)

ok thanks for the confirmation

@krumnack can you please merge?

added review-approved label and removed review-pending-expert label

mentioned in commit d3260fd7

merged

added sweep:ignore label