adding beam spot weights to InDetPhysVal monitoring

Adding beamspot weight functionality to InDet PhysVal code.

All plotting classes updated. We will likely need experts to comment and adapt some parts of the code. @goblirsc @vcairo

Plots: https://miochoa.web.cern.ch/miochoa/webDir_weights/

@jferrand @dhayden

added 1 commit

• fe8de337 - adding 1D Hits, Vertex; TEfficiency too

Compare with previous version

added 1 commit

• 6d72a45e - fill weighted

Compare with previous version

added 1 commit

• 95501073 - Add some default values to bsweights

Compare with previous version

added 1 commit

• de659c69 - new th2f, some of vertextruthmatching (but not all)

Compare with previous version

added 1 commit

• 7c1c0431 - Add functionality for weighting TProfile plots

Compare with previous version

maybe we should update the description now that TProfile, TEfficiency and TH2 functionality has been added

added 1 commit

• c0404810 - Add remaining non-ntuple fills in monitoring code

Compare with previous version

added 1 commit

• 2f4a257c - last remaining fillHistos

Compare with previous version

changed the description

marked this merge request as ready

This merge request affects 1 package:

• InnerDetector/InDetValidation/InDetPhysValMonitoring

This merge request affects 32 files. Since this is a long list, it will not be printed.

Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe as watchers

added InnerDetector JetEtmiss master review-pending-level-1 labels

CI Result SUCCESS (hash 2f4a257c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32138]

Hi @miochoa,

one small comment from L1 side. Can you please take a look?

Thanks, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

Dear @miochoa @jferrand,

thanks so much for this huge effort! Just one minor question, shall we make the application of BS weights steerable by a BooleanProperty?

Hi @goblirsc ,
we haven't done that with the other implementations, but it does make sense to have this as a steerable option (defaulting to being on). I'll push a fix for the issue @vaustrup identified and then think about this.

added 1 commit

• a7c564a1 - fix loop over track weights that had duplicate naming

Compare with previous version