Skip to content
Snippets Groups Projects

adding beam spot weights to InDetPhysVal monitoring

Merged Ines Ochoa requested to merge miochoa/athena:master-miochoa--adding-weights into master

Adding beamspot weight functionality to InDet PhysVal code.

All plotting classes updated. We will likely need experts to comment and adapt some parts of the code. @goblirsc @vcairo

Plots: https://miochoa.web.cern.ch/miochoa/webDir_weights/

@jferrand @dhayden

Edited by Ines Ochoa

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @miochoa,

    one small comment from L1 side. Can you please take a look?

    Thanks, Volker (L1)

  • Dear @miochoa @jferrand,

    thanks so much for this huge effort! Just one minor question, shall we make the application of BS weights steerable by a BooleanProperty?

  • Hi @goblirsc ,
    we haven't done that with the other implementations, but it does make sense to have this as a steerable option (defaulting to being on). I'll push a fix for the issue @vaustrup identified and then think about this.

  • James Ferrando added 1 commit

    added 1 commit

    • a7c564a1 - fix loop over track weights that had duplicate naming

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading