Skip to content
Snippets Groups Projects

AT: Adding configurable parameter for testing custom electron ID SF files

Merged AT: Adding configurable parameter for testing custom electron ID SF files
(removed):21.2-CustomEID into 21.2
All threads resolved!
Merged Bjoern Wendland requested to merge (removed):21.2-CustomEID into 21.2
All threads resolved!

A configurable parameter is added to AT that allows for custom SF files for the electron ID. This parameter should only be used by experts for testing SFs.

Edited by Bjoern Wendland

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bjoern Wendland added 1 commit

    added 1 commit

    • c74ed9d3 - Adjusting naming of variables, enhancing description and printing SF file path

    Compare with previous version

  • Bjoern Wendland marked this merge request as ready

    marked this merge request as ready

  • Bjoern Wendland changed title from WIP: Custom electron ID SFs to AT: Adding configurable parameter for testing custom electron ID SF files

    changed title from WIP: Custom electron ID SFs to AT: Adding configurable parameter for testing custom electron ID SF files

  • Bjoern Wendland changed the description

    changed the description

  • Bjoern Wendland added AnalysisTop label

    added AnalysisTop label

  • Bjoern Wendland resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 124K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/TopConfiguration/TopConfig.h

    :pencil: 184K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/Root/TopConfig.cxx

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 124K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/TopConfiguration/TopConfig.h

    :pencil: 184K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/Root/TopConfig.cxx

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
    • PhysicsAnalysis/TopPhys/xAOD/TopCPTools
    • PhysicsAnalysis/TopPhys/xAOD/TopConfiguration

    Affected files list will not be printed in this case

    Adding @bmondal ,@spalazzo ,@omajersk ,@mvanadia ,@tdado as watchers

  • ATLAS Robot added 21.2 Analysis Egamma review-pending-level-1 labels

    added 21.2 Analysis Egamma review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

    • Developers and shifters need to wait for both results, sometimes for additional hour or two.
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash c74ed9d3)

    AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 6
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31942]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash c74ed9d3)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :warning:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :warning: AthDerivation: number of compilation errors 0, warnings 17
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 727]

  • G
    Giovanni Marchiori @gmarchio ·
    Developer

    Code looks OK to me, approved. @krumnack please merge

    Cheers, Giovanni (AR shifter)

  • Giovanni Marchiori added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Nils Erik Krumnack merged

    merged

  • Nils Erik Krumnack mentioned in commit 98eeba75

    mentioned in commit 98eeba75

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Nils Erik Krumnack mentioned in commit omajersk/athena@125ad926

    mentioned in commit omajersk/athena@125ad926

  • Oliver Majersky mentioned in merge request !51718 (merged)

    mentioned in merge request !51718 (merged)

    • Please register or sign in to reply