Preparations to enable tracking geom cond alg by default

This contains bugfixes for CA and minor changes to prepare for enabling trackinggeomcondalg by default.

See also: ATLASRECTS-6304

Pinging @goetz @rlangenb @elmsheus @mhodgkin

added full-unit-tests label

This merge request affects 1 package:

• InnerDetector/InDetExample/InDetRecExample

This merge request affects 1 file:

• InnerDetector/InDetExample/InDetRecExample/python/TrackingCommon.py

Adding @goetz ,@amorley ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

changed the description

removed InnerDetector master review-pending-level-1 labels

CI Result FAILURE (hash 19155be1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32855]

@emoyse is there a particular reason why the review label was removed? From the description, I see that this MR may just be to check the CI status, is that so? If not can you add the label back? cheers -- L1

No - I didn't do this on purpose. I assume it was because I was editing the description as the labels were added. In any case, there's not a lot of point you reviewing this at the moment.

added master review-user-action-required labels

added 54 commits

• 19155be1...2e44a455 - 48 commits from branch atlas:master
• 91c2973d - Enable tracking geom cond alg by default
• 896ece15 - Improve the debugging output when privatetoolhandlearrays do not match
• 8c8267a5 - Match old/new SCT conf names and fix bug in new config
• 980ee4b4 - Minor fix for typo in comment in _getInDetTrackingGeometryBuilder
• f88b41c7 - Fix CA bug where type was being compared to name. Fix indentation of debug messages.
• 75ee3e1b - Use TrackingGeometryCondAlgCfg if use_tracking_geometry_cond_alg

Compare with previous version

I've pushed new changes. I found a bug in the ComponentAccumulator itself (which I would normally split off into a different MR, but this is urgent). I also fixed some new/old differences.

added urgent label

This merge request affects 5 packages:

• Control/AthenaConfiguration
• InnerDetector/InDetConfig
• InnerDetector/InDetExample/InDetRecExample
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/TgcRawDataMonitoring
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@rosati ,@wleight ,@sroe ,@ssnyder ,@jojungge as watchers

added Core DQ InnerDetector MuonSpectrometer Tracking review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash 75ee3e1b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32973]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• e9872e1c - Fix for case where configurable is just a string

Compare with previous version

This merge request affects 5 packages:

• Control/AthenaConfiguration
• InnerDetector/InDetConfig
• InnerDetector/InDetExample/InDetRecExample
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/TgcRawDataMonitoring
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@rosati ,@wleight ,@sroe ,@ssnyder ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash e9872e1c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 1
AthGeneration: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32995]