MuonTrackSterring - Initial clean-up

Hi,

the MR is preparatory to remove the mutable data members of the MuonTrackSterring and also to clean up the package in general. The main change introduces here is the split of the Primitive classes MuPatHit, MuPatCandidateBase, and MuPatSegment into a separate package. I decided to do so as these data structures are piped through the tools and the package is missing a proper interface for almost all tools. If interface classes will be added they must depend on these data structures.

added full-unit-tests label

Jenkins please retry a build

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecToolInterfaces
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

added MuonSpectrometer master labels

CI Result FAILURE (hash fa0db252)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33099]

closed

reopened

marked this merge request as ready

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecToolInterfaces
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

added review-pending-level-1 label

added 1 commit

• bf7e8320 - Make sure to keep the MuonSegment until the loop is finished

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecToolInterfaces
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

CI Result FAILURE (hash 61115640)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33118]

CI Result FAILURE (hash bf7e8320)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33127]

added 1 commit

• da54467e - Fix segfaults

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecToolInterfaces
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

CI Result FAILURE (hash da54467e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33168]

marked this merge request as draft

removed review-pending-level-1 label

added 4 commits

• 92d267e0 - Use smart pointers
• bcc9cab3 - Smart pointers
• 48dbb28d - Smart pointers
• bf77d512 - Const parsing

Compare with previous version

added 1 commit

• 0b20bf96 - Further pointer clean up

Compare with previous version

marked this merge request as ready

WARNING: big files (>100K) are found in the changeset

120K in file MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools/src/MooTrackFitter.cxx

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecToolInterfaces
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

added review-pending-level-1 label

CI Result FAILURE (hash 0b20bf96)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33194]

marked this merge request as draft

removed review-pending-level-1 label

added 245 commits

• 0b20bf96...36d1b384 - 242 commits from branch atlas:master
• a65d3f7b - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into ATLASRECTS-6306
• e9b17f4a - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into ATLASRECTS-6306
• 45eb03eb - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into ATLASRECTS-6306

Compare with previous version

added 47 commits

• 45eb03eb...62889ed3 - 46 commits from branch atlas:master
• c2d0a95c - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into ATLASRECTS-6306

Compare with previous version

added 1 commit

• 1db2e93e - Add common garbage container

Compare with previous version

closed

reopened

added 1 commit

• 7885476b - Reindentation of MuonSegmentTrackMaker

Compare with previous version

added 1 commit

• 67b57d15 - Split the primitive classes of the TrackSteering into a separate package

Compare with previous version

removed full-unit-tests label

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

124K in file MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools/src/MooTrackFitter.cxx

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuPatPrimitives
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

added 1 commit

• 043ce444 - Remove finalize

Compare with previous version

marked this merge request as ready

changed title from Draft: MuonTrackSteering - Remove mutable gabage members to MuonTrackSterring - Initial clean-up

changed the description

WARNING: big files (>100K) are found in the changeset

124K in file MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools/src/MooTrackFitter.cxx

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuPatPrimitives
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

added review-pending-level-1 label

added 1 commit

• 49beea61 - Fix missing include

Compare with previous version

WARNING: big files (>100K) are found in the changeset

124K in file MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools/src/MooTrackFitter.cxx

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuPatPrimitives
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

CI Result FAILURE (hash 67b57d15)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33381]