Improved diffing functionality of confTool

This is small diffing improvement kicking in when the default setting is X and the value actually set is in JO StoreGateSvc+X. With --ignoreDefaults this case is ignored.

Aside from that there is a major refactor

• loading modifiers went into separate functions
• coloring code in diffing function is modified to be more readable (and more compact)
• plain config display (-p option) also does coloring now

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 2 files:

• Control/AthenaConfiguration/python/iconfTool/models/loaders.py
• Control/AthenaConfiguration/share/confTool.py

Adding @ssnyder as watcher

added Core master review-pending-level-1 labels

CI Result SUCCESS (hash e1bf0947)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33193]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 6d9b916d

added sweep:ignore label

Hi @tbold ,

It looks like this MR introduced a log-difference in the Bootstrap-test:

http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7G8AthenaOpt/ARDOC_TestLog_2021-05-10T2101/Control_AthenaCommon___AthenaCommonConf__AthenaCommonTest__m.html

Can you please update the reference file?

Thanks, Walter

Interesting! So we happen to use diffing in the tests. Sure, will provide the fix asap.

mentioned in merge request !43418 (merged)