TriggerMenuMT: stop building LVL1 JSON menus

Stop producing the (Run-3) L1 menu JSON files during the build and do not install them as part of the release. Instead introduce unit tests for each L1 menu. This might help in reducing sporadic build failures seen in the TriggerMenuMT package (ATR-21862). The legacy L1 XML menus continue to be produced during the build until all remaining clients are migrated to JSON (ATR-21862).

This change (but for both XML and JSON) was first attempted in !33843 (merged) but reverted again due to ATR-21612. So this time we only remove the building of the JSON files.

To produce the L1 JSON files manually, there are several options:

1. Build the package and run ctest. This will produce the menu files in your build area under: Trigger/TriggerCommon/TriggerMenuMT/Menus
2. Run the generation script directly, e.g. generateL1MenuRun3.py Physics_pp_run3_v1
3. Run a full athena[HLT] trigger job

cc @mark and menu coordinators (@khoo @dzanzi @markowen) as this may have implications for workflows where the L1 JSON files are required (e.g. DB upload)

added full-build label

build area is cleaned as MR is labeled as full-build

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 2 files:

• Trigger/TriggerCommon/TriggerMenuMT/CMakeLists.txt
• Trigger/TriggerCommon/TriggerMenuMT/scripts/generateL1MenuMT.sh

Adding @hrussell ,@dzanzi ,@bernius as watchers

added Trigger TriggerMenu master review-pending-level-1 labels

For data processing, we ask menu experts to generate the json files anyway (see https://twiki.cern.ch/twiki/bin/view/Atlas/TriggerOnlineMenuUploadRun3). For MC, in run-2, we did used to take the xml files directly from the release (see https://twiki.cern.ch/twiki/bin/view/Atlas/TriggerDBReplication). However, I don't particularly see a problem with running a short job to make the json files. So all fine with me.

Mark

changed the description

Thanks @fwinkl - I don't see an issue either. Its good that you added the tests so that we make sure that any changes don't affect the other menus, and I hope it also makes the build quicker.

One note for clarification I don't think the json files actually ever made it to the install of the release even though they were created during the build (another reason to remove this building!).

For Run2 MC we kept a hard copy of the xmls (as well as uploading to the DB) so it was useful just to link to the files in the release for that, but given this isn't an option anyway we should just revisit if that backup is needed or how to do it better for Run3. For data hopefully the new DB structure will remove any of the complications about passing xml files to the CTP group as they can just download the json directly rather than links to the release or otherwise.

Cheers, Mark

CI Result FAILURE (hash 108d800b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33329]

Unrelated crash in q431 (ATLASRECTS-6301).

Approving the MR.

ML, L1 shifter

added review-approved label and removed review-pending-level-1 label

mentioned in commit 1b96f383

merged

added sweep:ignore label