Update the beam spot code to make it Run in Release 22

A series of small updates to get the beams pot code running in Release 22. The changes include:

• required for Python3 migration
• No longer use AthenaROOTAccess

added 1 commit

• 7a28bc24 - Add back InDetBeamSpotRooFit as a Tool

Compare with previous version

marked this merge request as ready

This merge request affects 2 packages:

• InnerDetector/InDetCalibAlgs/InDetBeamSpotFinder
• InnerDetector/InDetExample/InDetBeamSpotExample

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

CI Result SUCCESS (hash 7a28bc24)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33756]

This looks fine aside from the minor flake-8 warnings. I've commented inline where they crop up. Tom - L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

added 2 commits

• 70f3c60c - Fix Flake8 errors
• 656267fe - Merge branch 'BeamspotRunningUpdateR22' of...

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetCalibAlgs/InDetBeamSpotFinder
• InnerDetector/InDetExample/InDetBeamSpotExample

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label

@tneep -- sorry i missed the Flake8 warnings. -- they are fixed now

CI Result SUCCESS (hash 656267fe)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33781]