TLA chain name changes (ATR-20395, ATR-21594) and bug-fix for TLA photon (ATR-23448)

In the current MR we:

• changed JetDS position in jet chains (ATR-20395)
• added low-threshold L1Topo chain for potential end-of-fill / low lumi / early menu (ATR-20395)
• added test chain for TLA multijet from HH4b seed (ATR-21594)
• fixed issue on photon container threshold to be lower wrt the photon chain threshold to avoid problem in ATR-23448 (with @mmontell). This is a temporary fix for the chain we're testing, but will need a check that this does not happen when parsing the chain name, which will happen in a subsequent MR.

Update 23/05/2021: Fixing the multijet test chain, but also testing a single TLA stream for jets and photons. Update 23/05/2021: testing of a single TLA stream in its own branch, fixed multijet test chain Update 25/05/2021: fixing reference for multijet test chain, more edge cases for photon TLA

WARNING: big files (>100K) are found in the changeset

104K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigEgammaHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@dbakshig ,@iriu ,@vmartin ,@okumura ,@carquin ,@fernando ,@bernius ,@hrussell ,@ademaria ,@malconad ,@cjmeyer as watchers

added Egamma Trigger TriggerMenu changes-trigger-counts master review-pending-level-1 labels

CI Result SUCCESS (hash 3a5413ca)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33758]

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

Please fix the issue pointed out by @khoo

added 155 commits

• 3a5413ca...abae87b1 - 152 commits from branch atlas:master
• 5cdfb071 - Merge remote-tracking branch 'upstream/master' into TLAPEB
• 1dd6618f - Merge remote-tracking branch 'upstream/master' into TLAPEB
• 0c1e532d - XMerge remote-tracking branch 'upstream/master' into TLAPEB

Compare with previous version

added 1 commit

• 09e81a25 - Fixed multijet chain name

Compare with previous version

WARNING: big files (>100K) are found in the changeset

108K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigEgammaHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@dbakshig ,@iriu ,@vmartin ,@okumura ,@carquin ,@jodafons ,@fernando ,@bernius ,@hrussell ,@ademaria ,@malconad ,@cjmeyer as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

108K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigEgammaHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@dbakshig ,@iriu ,@vmartin ,@okumura ,@carquin ,@jodafons ,@fernando ,@bernius ,@hrussell ,@ademaria ,@malconad ,@cjmeyer as watchers

CI Result FAILURE (hash 09e81a25)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33874]

CI Result SUCCESS (hash 0c1e532d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33871]

added review-user-action-required label and removed review-pending-level-1 label

added 174 commits

• 09e81a25...0c9a6c6f - 173 commits from branch atlas:master
• fd983a64 - Merge remote-tracking branch 'upstream/master' into TLAPEB

Compare with previous version

WARNING: big files (>100K) are found in the changeset

108K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigEgammaHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@dbakshig ,@iriu ,@vmartin ,@okumura ,@carquin ,@jodafons ,@fernando ,@bernius ,@hrussell ,@ademaria ,@malconad ,@cjmeyer as watchers

added review-pending-level-1 label and removed review-user-action-required label

marked this merge request as draft

changed the description

marked this merge request as ready

changed the description

added 1 commit

• 7612e77d - Fixed problem in seed of TLA multijet chain

Compare with previous version

WARNING: big files (>100K) are found in the changeset

108K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigEgammaHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@dbakshig ,@iriu ,@vmartin ,@okumura ,@carquin ,@jodafons ,@fernando ,@bernius ,@hrussell ,@ademaria ,@malconad ,@cjmeyer as watchers

CI Result FAILURE (hash 7612e77d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34077]

CI Result FAILURE (hash fd983a64)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 5
AthSimulation: number of compilation errors 0, warnings 1
AthGeneration: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 1
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34071]

resolved all threads

Some compilation warnings are probably unrelated, but tests failures probably not.... Caterina could you please have a look ?

Thanks, Pavol [as L2 MR shifter]

added review-user-action-required label and removed review-pending-level-1 label

I am not sure why the error occurs. It says: AssertionError: ERROR IN CHAIN HLT_j60_j45_2j20_JetDS_L1J45p0ETA21_3J15p0ETA25 definition, l1 thresholds specified ['FSNOSEED', 'FSNOSEED', 'FSNOSEED', 'FSNOSEED'] have different length than chain parts ['j60', 'j45', '2j20']

but the chain now has only 3 l1 thresholds as it should be

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

108K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigEgammaHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@dbakshig ,@iriu ,@vmartin ,@okumura ,@carquin ,@jodafons ,@fernando ,@bernius ,@hrussell ,@ademaria ,@malconad ,@cjmeyer as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 7612e77d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34143]

It seems a reference file still needs to be updated.

Kira (L1)

added review-user-action-required label and removed review-pending-level-1 label

Indeed thanks, I think the problem here is the lack of commit of the new reference - fixing it now.

marked this merge request as draft

changed the description

added 112 commits

• 7612e77d...b7562360 - 110 commits from branch atlas:master
• bd2d9ef2 - Merge remote-tracking branch 'upstream/master' into TLAPEB
• f78799a7 - Updated references

Compare with previous version

The references have been updated, we're still thinking of the photon fix for https://its.cern.ch/jira/browse/ATR-23448 - if we manage something before the end of the working day we'll add it in, but otherwise we'll patch it and remove the WIP.

removed review-user-action-required label