Remove option to change TRT extension PHF requirement
Remove the option to change the TRT extension PHF requirement which was introduced for test purposes in !41055 (merged).
The PHF requirement is now always 0.3 as validated in ATLASRECTS-6275
Merge request reports
Activity
This merge request affects 1 package:
- InnerDetector/InDetExample/InDetRecExample
This merge request affects 2 files:
- InnerDetector/InDetExample/InDetRecExample/python/ConfiguredNewTrackingCuts.py
- InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py
added InnerDetector master review-pending-level-1 labels
CI Result FAILURE (hash 9b52fef8)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33922]- Resolved by Christian Grefe
The q431 test is failing with differences to the reference file. Could you please investigate and update the reference if the changes are expected?
Thanks, Kira (L1)
added review-user-action-required label and removed review-pending-level-1 label
added Tools review-pending-level-1 labels and removed review-user-action-required label
- Resolved by Christian Grefe
Hi @cgrefe,
would this MR invalidate the "second round CP" r-tags, which attempt to set this property? Probably not a real issue, we can just make new ones, but it would prevent people from using them as starting points for their own transforms (I tend to point people to the latest physval / CPprod r-tags when they look for a working r22 transform).
Cheers, Max
CI Result FAILURE (hash 16226c61)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33970] CI Result FAILURE (hash 16226c61)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33982]- Resolved by Christian Grefe
Not sure whether the CI failures are related, but setting review-user-action-required while there are unresolved threads. Tom - L1 shifter
added review-user-action-required label and removed review-pending-level-1 label
Actually we seem to have a lot of failures in Q431 all look like some short of MT race. It seems to affect mainly CI that started 4-5 hours ago.
E.g around / after 16:30 CET from a quick browsing around .
For example looking at !43750 (merged) :
- The one the bot started at May 21 , 2021 3:29pm GMT +1 passes finishing at 21 , 2021 6:25pm GMT+01
- The one the bot started May 21 4:46pm GMT+1 fails May 21, 2021 8:11pm GMT+0100
As they finish we have piled-up a few failed
CI
.Let me mention @aundrus , @emoyse , @ssnyder .
Do not know if we need to open a JIRA or could be a transient issue (Friday's some times tent to be problematic)
Edited by Christos Anastopoulos