ATLASRECTS-6089,ATLASRECTS-6357 : Another take . Hopefully removing all spurious expectations of CaloCalTopoClusters.constituentClusterLinks

ATLASRECTS-6089,ATLASRECTS-6357 : Another take . Hopefully removing all spurious expecations of CaloCalTopoClusters.constituentClusterLinks

@emoyse and @ssnyder I suspect that !43676 (merged) has something to do with the latest failures. It might be a coincidence but might be not, some of the failed logs. Reference ".constituentClusterLinks". e.g

RAWtoESD 23:24:13 SGInputLoader                                          9     0 WARNING unable to find proxy for  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+CaloCalTopoClusters.constituentClusterLinks' )

Not sure is this will fix it hope so. The issue is that in reality we do

egammaClustersAuxDyn.constituentClusterLinks

from e/gamma std reco and we also want

MuonClusterCollectionAuxDyn.constituentClusterLinks

done from the cluster Association tools.

These are links to

CaloCalTopoClusters

but we do not want e.g

CaloCalTopoClustersAuxDyn.constituentClusterLinks

the other side.

@goblirsc reported some issues on derivations due to having these kind of "CaloCalTopoClusters.constituentClusterLinks"

Anyhow, this is a try to convince the relevant algs that somehow actually want need "MuonClusterCollection.constituentClusterLinks" pointing to CaloCalTopoClusters.

Worse comes to worse we can revert the other MR and try to figure a better way out.

From lxr there seems that these here are the only non-egamma places.

https://acode-browser1.usatlas.bnl.gov/lxr/search?%21v=head&_filestring=&_string=constituentClusterLinks