RootCollection+ImplicitCollection+CollectionBase: Enable thread-safety checking.

Enable thread-safety checking and fix identified issues. Make methods of ICollectionMetadata non-const.

This merge request affects 3 packages:

• Database/APR/CollectionBase
• Database/APR/ImplicitCollection
• Database/APR/RootCollection

Affected files list will not be printed in this case

Adding @mnowak ,@ssnyder as watchers

added Database JetEtmiss master review-pending-level-1 labels

CI Result SUCCESS (hash d9dace98)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34207]

Changes and CI look fine. Approving.

Kira (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 0b84caab

added sweep:ignore label