egammaMVACalibAnalysis+ElectronPhotonFourMomentumCorrection+LArCellRec: Fix cppcheck warnings.

Redundant pointer comparison. Pass large objects by const reference, not by value. Avoid postincrement for iterator classes.

This merge request affects 3 packages:

• LArCalorimeter/LArCellRec
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection
• PhysicsAnalysis/ElectronPhotonID/egammaMVACalibAnalysis

Affected files list will not be printed in this case

Adding @pavol as watcher

added Analysis Egamma JetEtmiss LAr analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash 78fef3c6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34209]

Failing test seems unrelated. Will restart the CI.

Kira (L1)

Jenkins please retry a build

This merge request affects 3 packages:

• LArCalorimeter/LArCellRec
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection
• PhysicsAnalysis/ElectronPhotonID/egammaMVACalibAnalysis

Affected files list will not be printed in this case

Adding @pavol as watcher

CI Result SUCCESS (hash 78fef3c6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34218]

Changes and CI look fine. Approving.

Kira (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit e0bd5da0

added sweep:ignore label