TrigT1MuctpiPhase1: make simulation algorithm non-reentrant
The MuCTPI simulation is not actually thread-safe. Until this is fixed (ATR-23540) revert the algorithm to be non-reentrant.
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigT1/TrigT1MuctpiPhase1
This merge request affects 2 files:
- Trigger/TrigT1/TrigT1MuctpiPhase1/src/MUCTPI_AthAlg.cxx
- Trigger/TrigT1/TrigT1MuctpiPhase1/src/MUCTPI_AthAlg.h
Adding @afaulkne as watcher
added Trigger master review-pending-level-1 labels
CI Result FAILURE (hash eec66bda)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34574]- Resolved by Frank Winklmeier
you could also add
bool isReEntrant() const override final { return false; }
mentioned in merge request !44004 (merged)
added review-user-action-required label
removed review-pending-level-1 label
added 1 commit
- 8f9916cc - TrigT1MuctpiPhase1: make simulation algorithm non-reentrant
This merge request affects 1 package:
- Trigger/TrigT1/TrigT1MuctpiPhase1
This merge request affects 2 files:
- Trigger/TrigT1/TrigT1MuctpiPhase1/src/MUCTPI_AthAlg.cxx
- Trigger/TrigT1/TrigT1MuctpiPhase1/src/MUCTPI_AthAlg.h
Adding @afaulkne as watcher
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 8f9916cc)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34744]added review-approved label and removed review-pending-level-1 label
mentioned in commit 94b279c2
added sweep:ignore label