Skip to content
Snippets Groups Projects

Update particle flow e/p file for reprocessing

All threads resolved!

This provides a new e/p reference file based on the round 2 CP samples. The name is updated to better reflect its origin. The config is updated in a similar way.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi! I left a comment regarding the CI warnings... Will change label to review-user-action-required until solved.

    Apart from that, all code changes are fine from L1 side.

    Cheers, Francisco (L1)

  • added 1 commit

    • 0b4473f5 - Fix typo in e/p file name for trigger config.

    Compare with previous version

  • Mark Hodgkinson resolved all threads

    resolved all threads

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 308K in file Reconstruction/eflowRec/src/eflowCellEOverPTool_Run2_mc20_JetETMiss.cxx

  • This merge request affects 2 packages:

    • Reconstruction/eflowRec
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @goetz ,@mhodgkin as watchers

  • :white_check_mark: CI Result SUCCESS (hash 0b4473f5)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35252]

  • CI warnings have been resolved and MR has been reviewed by a previous L1 shifter. Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Conflicts now...

  • Mark Hodgkinson added 180 commits

    added 180 commits

    Compare with previous version

  • Resolved conflict.

    Cheers,

    Mark

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 308K in file Reconstruction/eflowRec/src/eflowCellEOverPTool_Run2_mc20_JetETMiss.cxx

  • This merge request affects 2 packages:

    • Reconstruction/eflowRec
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @goetz ,@mhodgkin as watchers

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

  • :white_check_mark: CI Result SUCCESS (hash f5e1781d)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35347]

  • Conflicts resolved and CI still passes -- re-approved. L1

  • mentioned in commit 8a7cd885

  • Please register or sign in to reply
    Loading