Skip to content
Snippets Groups Projects

Add CA getPrimaryAndMerge handy shortcut method

Merged Tomasz Bold requested to merge tbold/athena:add-getPrimaryAndMerge into master
All threads resolved!

It was discussed that such a method would be useful to cut some boilerplate. Indeed, as exemplified in this MR (for ID tracking) it does so nicely.

@wlampl @tadej @goetz

Merge request reports

Pipeline #2713676 passed

Pipeline passed for 7e9500a5 on tbold:add-getPrimaryAndMerge

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 3 years ago (Jun 14, 2021 5:13pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Bold added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • Control/AthenaConfiguration
    • InnerDetector/InDetConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe ,@ssnyder as watchers

  • :white_check_mark: CI Result SUCCESS (hash 7e9500a5)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35291]

  • Louis-Guillaume Gagnon resolved all threads

    resolved all threads

  • looks fine, and already reviewed by an expert, approving. -- L1

  • mentioned in commit 9e0d97e6

  • Please register or sign in to reply
    Loading