22.0-cppcheck-InDetAlignmentMonitoring

WARNING: big files (>100K) are found in the changeset

324K in file InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonResiduals.cxx

120K in file InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonGenericTracks.cxx

160K in file InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonEfficiencies.cxx

This merge request affects 1 package:

InnerDetector/InDetMonitoring/InDetAlignmentMonitoring

This merge request affects 11 files:

InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonEfficiencies.cxx
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonGenericTracks.cxx
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonGenericTracks.h
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonNtuple.cxx
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonPVBiases.cxx
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonPVBiases.h
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/IDAlignMonResiduals.cxx
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/utils/BeamSpotCalculator.C
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/utils/include/AtlasUtils.C
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/utils/macros/sctBarrelRes.cc
InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/utils/macros/sctBarrelResVsPt.cc

Adding @goetz ,@jajimene ,@martis ,@sroe as watchers

added DQ InnerDetector master review-pending-level-1 labels

CI Result SUCCESS (hash 010402ac)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35963]

Hi @sroe,

I've commented on three lines where the indentation is off. Let me know whether you want to change that or if this should be merged as-is.

Cheers, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

ok, thanks @vaustrup , I suggest you merge 'as is' and I make a JIRA ticket to run a formatter on the code. If I do that now, the number of changes will be huge and not functional changes.