Skip to content

Remove workaround for Gaudi parsing limitation

Stewart Martin-Haugh requested to merge remove_gaudi_workaround into master

Remove code that worked around a now-fixed bug in gaudi/Gaudi!1197 (merged).

Tested by generating two complete HLT configurations, one with, one without the changes. I expected to only see changes in JetMomentTools, but actually it looks like this change in GaudiPythonBindings propagates everywhere:

diff ref_conf/HLTJobOptions.json conf/HLTJobOptions.json                                                                                                                                                                     /afs/cern.ch/work/s/smh/ATR-23767
801,802c801,802
<             "BcToMuMuPion_dimuonMassRange": "[2500.0, 4300.0]",
<             "BcToMuMuPion_massRange": "[5500.0, 7300.0]",
---
>             "BcToMuMuPion_dimuonMassRange": "(2500.0, 4300.0)",
>             "BcToMuMuPion_massRange": "(5500.0, 7300.0)",
805c805
<             "BdToMuMuKstar0_KstarMassRange": "[700.0, 1100.0]",
---
>             "BdToMuMuKstar0_KstarMassRange": "(700.0, 1100.0)",
807c807
<             "BdToMuMuKstar0_massRange": "[4600.0, 5900.0]",
---
>             "BdToMuMuKstar0_massRange": "(4600.0, 5900.0)",
813c813
<             "BplusToMuMuKaon_massRange": "[4500.0, 5900.0]",
---
>             "BplusToMuMuKaon_massRange": "(4500.0, 5900.0)",
817c817
<             "BsToMuMuPhi1020_massRange": "[4800.0, 5800.0]",
---
>             "BsToMuMuPhi1020_massRange": "(4800.0, 5800.0)",
819c819
<             "BsToMuMuPhi1020_phiMassRange": "[940.0, 1100.0]",
---
>             "BsToMuMuPhi1020_phiMassRange": "(940.0, 1100.0)",
826c826
<             "Dimuon_massRange": "[100.0, 5500.0]",
---
>             "Dimuon_massRange": "(100.0, 5500.0)",
835,836c835,836
<             "LambdaBToMuMuProtonKaon_dimuonMassRange": "[2500.0, 4300.0]",
<             "LambdaBToMuMuProtonKaon_massRange": "[4800.0, 6400.0]",
---
>             "LambdaBToMuMuProtonKaon_dimuonMassRange": "(2500.0, 4300.0)",
>             "LambdaBToMuMuProtonKaon_massRange": "(4800.0, 6400.0)",

The actual physics results are unchanged: in principle before this we could have been appending to the list, but never actually did.

This change saves about 1 minute from HLT configuration, given how much python wrangling we do (discussed in ATR-23767). Probably smaller benefits for offline.

Note: I used the GitLab web interface to write this since I was having AFS issues, but I tested an identical changeset locally, was just unable to commit it.

Cheers,

Stewart

Merge request reports