Skip to content

TrkiPatFitterUtils clang warnings, TrkDistributedKalmanFilter clang-tidy fixes

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:FitProcedure,DistributedKalmanFilter_clang_fixes into master

Fix following warnings

build/atnight/localbuilds/nightlies/Athena/master/athena/Tracking/TrkFitter/TrkiPatFitterUtils/src/FitProcedure.cxx:227:25: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      measurementBase = std::move(m->measurementBase()->uniqueClone());
                        ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Tracking/TrkFitter/TrkiPatFitterUtils/src/FitProcedure.cxx:227:25: note: remove std::move call here
      measurementBase = std::move(m->measurementBase()->uniqueClone());
                        ^~~~~~~~~~                                   ~
/build/atnight/localbuilds/nightlies/Athena/master/athena/Tracking/TrkFitter/TrkiPatFitterUtils/src/FitProcedure.cxx:238:27: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
        materialEffects = std::move(m->materialEffects()->uniqueClone());
                          ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Tracking/TrkFitter/TrkiPatFitterUtils/src/FitProcedure.cxx:238:27: note: remove std::move call here
        materialEffects = std::move(m->materialEffects()->uniqueClone());
                          ^~~~~~~~~~                                   ~
/build/atnight/localbuilds/nightlies/Athena/master/athena/Tracking/TrkFitter/TrkiPatFitterUtils/src/FitProcedure.cxx:294:27: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
        materialEffects = std::move(m->materialEffects()->uniqueClone());
                          ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Tracking/TrkFitter/TrkiPatFitterUtils/src/FitProcedure.cxx:294:27: note: remove std::move call here
        materialEffects = std::move(m->materialEffects()->uniqueClone());

                          ^~~~~~~~~~                                   ~

Also prefer =make_unique rather than reset

Mentioning @ssnyder and @sroe

Edited by Christos Anastopoulos

Merge request reports