add L1Topo eFEX multiplicities reading from Opt inputs to CTPSimulation
add L1Topo eFEX multiplicities reading from Opt inputs to CTPSimulation (ATR-23671) on behalf of Patrick Czodrowski, who is currently unavailable.
Changes trigger counts for eEM phase-1 items only, according to the CI tests that I ran.
I also ran test_trig_data_v1Dev_L1SimOnly_build.py
but with 100 events instead of 20, and see the following diffs:
18,21c18,21
< L1_2eEM10 0
< L1_2eEM15VHI 0
< L1_2eEM20VH 0
< L1_2eEM8 0
---
> L1_2eEM10 2
> L1_2eEM15VHI 1
> L1_2eEM20VH 1
> L1_2eEM8 4
30c30
< L1_3jJ15p0ETA25_gXERHO40 0
---
> L1_3jJ15p0ETA25_gXERHO40 100
38c38
< L1_4jJ15p0ETA25 0
---
> L1_4jJ15p0ETA25 100
300c300
< L1_MU20_gXERHO30 0
---
> L1_MU20_gXERHO30 6
367,368c367,368
< L1_eEM10 0
< L1_eEM15 0
---
> L1_eEM10 10
> L1_eEM15 7
374,376c374,376
< L1_eEM20 0
< L1_eEM20VH 0
< L1_eEM20VHI 0
---
> L1_eEM20 7
> L1_eEM20VH 6
> L1_eEM20VHI 6
379,383c379,383
< L1_eEM22 0
< L1_eEM22VHI 0
< L1_eEM3 0
< L1_eEM7_MU20 0
< L1_eEM8 0
---
> L1_eEM22 6
> L1_eEM22VHI 3
> L1_eEM3 100
> L1_eEM7_MU20 1
> L1_eEM8 18
391,393c391,393
< L1_gXE50 0
< L1_gXEPUFIT20 0
< L1_gXEPUFIT50 0
---
> L1_gXE50 100
> L1_gXEPUFIT20 100
> L1_gXEPUFIT50 100
395c395
< L1_gXERHO50 0
---
> L1_gXERHO50 100
which are only in eEM, jJ and gXE items.
Merge request reports
Activity
added Trigger changes-trigger-counts master review-pending-level-1 labels
mentioned in merge request !44417 (closed)
CI Result FAILURE (hash d74082e6) Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37165] OK, two issues:
1)it suffers from the ElectronEgammaFastCaloHypo FPE (ATR-23520) I guess because more chains are now passing. If we're sticking to our rule of no FPEs in the CI then we need to fix this first. @fernando do you have time to check?
2)there is some additional diff in the etcut count:
diff --git a/Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref b/Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref --- a/Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref +++ b/Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref @@ -787,13 +787,13 @@ HLT_e5_etcut_L1eEM3: - eventCount: 9 + eventCount: 10 stepCounts: - 0: 12 - 1: 11 - 2: 9 - 3: 9 + 0: 17 + 1: 14 + 2: 10 + 3: 10 stepFeatures: - 0: 33 - 1: 33 - 2: 32 - 3: 17 + 0: 112 + 1: 71 + 2: 47 + 3: 41 HLT_e5_idperf_gsf_tight_L1EM3:
I can check this tomorrow: not obvious to me what would have changed it from 9 to 10 passed.
Hi @smh , why has
HLT_e5_etcut_L1eEM3
counts at all before this MR if L1_eEM3 accepts no events?Hi Daniele,
In the release it's 0 (see https://gitlab.cern.ch/atlas/athena/-/blob/4290e3d68e5b665d20f01d47fc6aa719f0713bd8/Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref#L788), locally I saw 9, and in the CI it has 10 counts.
Cheers,
Stewart
I suspect the difference is coming from !45352 (merged), which was merged yesterday morning. I can get the same diffs locally when running with r22.
CI Result FAILURE (hash 5354ed2f) Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37197] retrying the build after !45411 (merged)
CI Result SUCCESS (hash 5354ed2f) Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37278] added review-approved label and removed review-pending-level-1 label
mentioned in commit f6738cd7
added sweep:ignore label