Fix FPE in egamma software (ATR-23520)

There was a potential division by zero in the ringer normalization code. A check is added to avoid this, and fix failing tests.

marked this merge request as draft

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigMultiVarHypo

This merge request affects 1 file:

• Trigger/TrigHypothesis/TrigMultiVarHypo/src/tools/procedures/Norm1.cxx

added Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash 1b7c5d90)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37216]

added urgent label

adding the urgent label as this is making the CI tests fail in other MRs

Thanks, but this is still a draft with open threads, sending back to the developer (L1).

added review-user-action-required label and removed review-pending-level-1 label

@cjmeyer can you remove the draft label?

marked this merge request as ready

Hi,

I think given that this unblocks 45383 (which is critical), it should go in as is. However, @jodafons should make these changes in the future - I agree with Shaun's points and careful review.

Cheers, Stewart

removed review-user-action-required label

added review-approved review-user-action-required labels

removed review-user-action-required label

Hi All — Sounds good! I have the proposed changes implemented locally. The draft flag was because I was also curious about |energy|, which we're still following up on. Once it's clear what the best thing to do is I will open a separate MR that also includes the efficiency improvements. (Thanks @sroe !)

I'll close those threads then..

resolved all threads

Follow-up JIRA ticket: ATLASRECTS-6524

mentioned in commit cc137e8d

merged

Guys, sorry. for the delay. I am checking the changes proposed by Chris. I will need to figure out this but let put this in first (since we don't have any trigger count changes). I will check after.

added sweep:ignore label

mentioned in merge request !45383 (merged)