jet hypo ATR-23939 - crash possibly due to stateful Condition Filters.
ATR-23939 reports a crash, possibly due to a stateful class (a Condition Filter). This MR removes the state, and makes the filtering method const.
This change made the passing of a hypojet vector more natural than passing its begin and end iterators, and this modification was implemented.
Merge request reports
Activity
assigned to @peter
This merge request affects 1 package:
- Trigger/TrigHypothesis/TrigHLTJetHypo
This merge request affects 14 files:
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/ConditionFilter.cxx
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/ConditionFilter.h
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.cxx
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.h
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.cxx
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.h
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/IHypoJetVectorFilter.h
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/IJetsMatcher.h
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/JetGroupProduct.cxx
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/PassThroughFilter.cxx
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/PassThroughFilter.h
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/RangeFilter.cxx
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/RangeFilter.h
- Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolHelperNoGrouper.cxx
added JetEtmiss Trigger TriggerJet master review-pending-level-1 labels
CI Result FAILURE (hash 809269ff)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37405]added 1 commit
- f221981a - jet hypo - updae unit tests for changes to Filter interface, bug fix in RangeFilter.cxx
CI Result SUCCESS (hash f221981a)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37428]added review-approved label and removed review-pending-level-1 label
mentioned in commit 273fc899
added sweep:ignore label