Cleanup Inner Detector geometry configuration a bit
Cleanup Inner Detector geometry configuration a bit. Ideally we'll fully move away from grouped geometry configuration fragments as each client should setup dependencies properly.
/cc @jchapman
Merge request reports
Activity
added NewConfig full-unit-tests labels
This merge request affects 14 packages:
- DetectorDescription/GeoModel/AtlasGeoModel
- InnerDetector/InDetConfig
- InnerDetector/InDetDetDescr/InDetServMatGeoModel
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetMonitoring/SCT_Monitoring
- InnerDetector/InDetMonitoring/TRTMonitoringRun3
- Reconstruction/TrackCaloClusterRec/TrackCaloClusterRecTools
- Reconstruction/eflowRec
- Simulation/G4Atlas/G4AtlasTools
- Tracking/Acts/ActsGeometry
- Tracking/TrkExtrapolation/TrkExAlgs
- Tracking/TrkExtrapolation/TrkExUnitTests
- Trigger/TrigTools/TrigInDetConfig
Affected files list will not be printed in this case
Adding @goetz ,@jchapman ,@amorley ,@stavrop ,@nagano ,@sroe ,@mvozak ,@pagessin ,@cgrefe ,@jojungge ,@calfayan ,@mhodgkin ,@sutt ,@rbianchi as watchers
added 1 commit
- e5349c1a - Cleanup Inner Detector geometry configuration a bit
This merge request affects 14 packages:
- DetectorDescription/GeoModel/AtlasGeoModel
- InnerDetector/InDetConfig
- InnerDetector/InDetDetDescr/InDetServMatGeoModel
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetMonitoring/SCT_Monitoring
- InnerDetector/InDetMonitoring/TRTMonitoringRun3
- Reconstruction/TrackCaloClusterRec/TrackCaloClusterRecTools
- Reconstruction/eflowRec
- Simulation/G4Atlas/G4AtlasTools
- Tracking/Acts/ActsGeometry
- Tracking/TrkExtrapolation/TrkExAlgs
- Tracking/TrkExtrapolation/TrkExUnitTests
- Trigger/TrigTools/TrigInDetConfig
Affected files list will not be printed in this case
Adding @goetz ,@jchapman ,@amorley ,@stavrop ,@nagano ,@sroe ,@mvozak ,@pagessin ,@cgrefe ,@jojungge ,@calfayan ,@mhodgkin ,@sutt ,@rbianchi as watchers
added review-user-action-required label and removed review-pending-level-1 label
This merge request affects 14 packages:
- DetectorDescription/GeoModel/AtlasGeoModel
- InnerDetector/InDetConfig
- InnerDetector/InDetDetDescr/InDetServMatGeoModel
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetMonitoring/SCT_Monitoring
- InnerDetector/InDetMonitoring/TRTMonitoringRun3
- Reconstruction/TrackCaloClusterRec/TrackCaloClusterRecTools
- Reconstruction/eflowRec
- Simulation/G4Atlas/G4AtlasTools
- Tracking/Acts/ActsGeometry
- Tracking/TrkExtrapolation/TrkExAlgs
- Tracking/TrkExtrapolation/TrkExUnitTests
- Trigger/TrigTools/TrigInDetConfig
Affected files list will not be printed in this case
Adding @goetz ,@jchapman ,@amorley ,@stavrop ,@nagano ,@sroe ,@mvozak ,@pagessin ,@cgrefe ,@jojungge ,@calfayan ,@mhodgkin ,@sutt ,@rbianchi as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILURE (hash 09d779dc)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39114]removed review-pending-level-1 label
added review-user-action-required label
added 920 commits
-
09d779dc...c699a8ef - 919 commits from branch
atlas:master
- ea2ace58 - Cleanup Inner Detector geometry configuration a bit
-
09d779dc...c699a8ef - 919 commits from branch
This merge request affects 13 packages:
- DetectorDescription/GeoModel/AtlasGeoModel
- InnerDetector/InDetConfig
- InnerDetector/InDetDetDescr/InDetServMatGeoModel
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetMonitoring/SCT_Monitoring
- InnerDetector/InDetMonitoring/TRTMonitoringRun3
- Reconstruction/TrackCaloClusterRec/TrackCaloClusterRecTools
- Reconstruction/eflowRec
- Simulation/G4Atlas/G4AtlasTools
- Tracking/Acts/ActsGeometry
- Tracking/TrkExtrapolation/TrkExAlgs
- Trigger/TrigTools/TrigInDetConfig
Affected files list will not be printed in this case
Adding @goetz ,@jchapman ,@amorley ,@stavrop ,@nagano ,@sroe ,@mvozak ,@pagessin ,@cgrefe ,@jojungge ,@calfayan ,@mhodgkin ,@sutt ,@rbianchi as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILURE (hash ea2ace58)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40061]Hi @tadej,
there is still a ModuleNotFoundError
Py:ComponentAccumulator DEBUG Adding component EventSelectorAthenaPool/EventSelector to the job Traceback (most recent call last): File "/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/GeoModel/AtlasGeoModel/test/AtlasGeometryConfig_EVNT_test.py", line 30, in <module> acc.merge(AtlasGeometryCfg(ConfigFlags)) File "/build2/ci-builds/master/AthSimulation/build/AthSimulation/x86_64-centos7-gcc8-opt/python/AtlasGeoModel/AtlasGeoModelConfig.py", line 10, in AtlasGeometryCfg from InDetConfig.InDetGeometryConfig import InDetGeometryCfg File "/cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/ROOT/v6.24.00/x86_64-centos7-gcc8-opt/lib/ROOT/_facade.py", line 150, in _importhook return _orig_ihook(name, *args, **kwds) ModuleNotFoundError: No module named 'InDetConfig'
Can you please take a look?
Thanks, Volker (L1)
added review-user-action-required label and removed review-pending-level-1 label
removed full-unit-tests label