Skip to content
Snippets Groups Projects

[ATR-24164] Disable chains in menu from command line

Merged [ATR-24164] Disable chains in menu from command line
All threads resolved!
Merged Teng Jian Khoo requested to merge khoo/athena:master-TriggerMenu-disableChains into master
All threads resolved!

Allows adding disableChains=[...] to athena.py -c command to veto chains from the trigger menu, similar to selectChains functionality. Will only print a warning if nonexistent chains are specified, but will crash if both selectChains and disableChains are set, to avoid any ambiguity.

Needed urgently for upcoming production, to evade ATR-24052.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 3 years ago (Sep 16, 2021 5:21pm UTC)

Merge details

  • Changes merged into master with c4c5562d (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Teng Jian Khoo resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash d3658df0)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39157]

  • Vakhtang Tsulaia canceled the automatic merge

    canceled the automatic merge

  • GitLab has been acting up today. I guess this is why the auto-merge did not work. Will do that manually

  • mentioned in commit c4c5562d

  • :white_check_mark: CI Result SUCCESS (hash 6856b7cc)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39151]

  • Teng Jian Khoo mentioned in merge request !46551 (merged)

    mentioned in merge request !46551 (merged)

  • Please register or sign in to reply
    Loading