Expand eFEX tau
This MR contains the following changes:
-
Pull in ptMinToTopoCounts and isolation values from the Trigger menu for use in eFEX taus. This is necessary to be able to control eFEX tau isolation and minimum Pt from the menu as intended. This means changing those menu values will now affect actual trigger outputs
-
Set rCore isolation decision bit, seed bit, and UnD bit in the eFEX tau TOB. This is necessary to make the TOB agree with the spec. Because of this, the effect of isolation the tau TOBs can now be studied.
-
Fix the check in the eFEX tau algorithm that the central tower has >= 1 GeV. This was previously checked at 1 MeV scale instead of the 25 MeV eFEX scale. This should fix the problem of very low counts for eFEX taus compared to Run-2 as described in this JIRA ticket: https://its.cern.ch/jira/browse/ATR-24204
Merge request reports
Activity
added 1076 commits
-
0dddfce3...6f8f1ab1 - 1069 commits from branch
atlas:master - 29ac726d - Add ptMinTopo to formTauTOBWord
- 26511e49 - Isolation getters and menu
- 860095ba - Add isolation, seed, and und to eFEX tau
- 54998f7a - eFEX tau isolation menu updates
- 2284dc35 - getRCore fixes
- 5b7abcd6 - Add Rcore bitshift
- ace8c8c7 - Resolve pull
Toggle commit list-
0dddfce3...6f8f1ab1 - 1069 commits from branch
added Tau Trigger master review-pending-level-1 labels
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals 
cmake make required tests 
optional tests Full details available on this CI monitor view
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
added review-pending-level-2 label and removed review-pending-level-1 label
added changes-trigger-counts label
added review-user-action-required label
Hi @nicholas ,
the MR changes look good, thanks.
As you see in CI results, the MR changed trigger counts in required tests, Trigger_athenaHLT-test. This seems as intended, coul you please:
- confirm the changes look as intended to you?
- have one of the experts ok your changes, eg @afaulkne or @serodrig acc to expert watch-list, or confirm you have discussed with them?
- update the references? After these we can approve the MR. We should ensure changes-trigger-count flag is present.
If you find the time, could you please consider expanding the MR description, to contain (source):
a concise justification why the changes are necessary possible implications/side effects for other parts of the code link(s) to related JIRA tickets if applicable? The descriptions get automatically compiled to release notes, and release coordinators have been asking for more detailed MR descriptions. In your case, I expect clients using tau TOB would benefit.
Many thanks, L2
Edited by Liza Mijovicremoved review-pending-level-2 label
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
added review-approved label and removed changes-trigger-counts review-pending-level-1 labels
added review-user-action-required label
Hi @nicholas , GitLab is having troubles squashing commits on this MR. Could you please manually squash the commits and force-push to your branch? Thanks, and sorry for further delay.
added review-pending-level-1 label and removed review-approved review-user-action-required labels
removed review-pending-level-1 label
added review-approved label
enabled an automatic merge when the pipeline for 6a07b08d succeeds
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
mentioned in commit 2dd5f689
added sweep:ignore label
added Run3L1Calo label
